-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024-11-11, Version 23.2.0 (Current) #55741
Conversation
PR-URL: #55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
PR-URL: #55282 Fixes: #54300 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55531 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55467 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55412 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Move options that are only relevant for opening the database into a self-contained class. PR-URL: #55442 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #55512 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55503 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55501 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55507 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55493 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #55529 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55534 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #55536 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #55547 Refs: #55538 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55530 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
When a ESM module cannot be loaded by require due to the presence of TLA, its module status would be stopped at kInstantiated. In this case, when it's imported again, we should allow it to be evaluated asynchronously, as it's also a common pattern for users to retry with dynamic import when require fails. PR-URL: #55502 Fixes: #55500 Refs: #52697 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55457 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Fixes #54417 Ref: #55452 PR-URL: #55458 Refs: #55452 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #55558 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #55559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
Trim off irrelevant internal stack frames for require(esm) warnings so it's easier to locate where the call comes from when --trace-warnings is used. PR-URL: #55496 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
This tracks the asynchronicity in the ModuleWraps when they turn out to contain TLA after instantiation, and throw the right error (ERR_REQUIRE_ASYNC_MODULE) when it's required again. It removes the freezing of ModuleWraps since it's not meaningful to freeze this when the rest of the module loader is mutable, and we can record the asynchronicity in the ModuleWrap right after compilation after we get a V8 upgrade that contains v8::Module::HasTopLevelAwait() instead of searching through the module graph repeatedly which can be slow. PR-URL: #55520 Fixes: #55516 Refs: #52697 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: #55486 Reviewed-By: Jake Yuesong Li <[email protected]>
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer add `icu-uc` when linking to shared libraries. This results in undefined symbols/references when trying to build with system ICU 76. [^1]: unicode-org/icu@199bc82 PR-URL: #55563 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55506 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
PR-URL: #55575 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55430 Refs: #52464 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Small efficiency improvement over NewFromUtf8(): the literal's length is known at compile time, so V8 doesn't have to call strlen() or ToLocalChecked(). PR-URL: #55581 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282 PR-URL: #55741
2c07f86
to
69c6bf2
Compare
CI: https://ci.nodejs.org/job/node-test-pull-request/63449/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v23.x #55741 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.01%
==========================================
Files 653 654 +1
Lines 187479 187665 +186
Branches 36089 36125 +36
==========================================
+ Hits 165769 165930 +161
- Misses 14955 14965 +10
- Partials 6755 6770 +15
|
PR-URL: #55745 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55766 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
PR-URL: #55758 Fixes: #55733 Refs: #55733 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
69c6bf2
to
f2bac99
Compare
Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282 PR-URL: #55741
Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282 PR-URL: #55741
f2bac99
to
a83fbdb
Compare
Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282 PR-URL: #55741
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N
Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) nodejs#55681 doc: * move typescript support to active development (Marco Ippolito) nodejs#55536 * add jazelly to collaborators (Jason Zhang) nodejs#55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) nodejs#55282 PR-URL: nodejs#55741
535f1b0d4c
] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681fa61dced44
] - doc: move typescript support to active development (Marco Ippolito) #555369dcca5441b
] - doc: add jazelly to collaborators (Jason Zhang) #55531f628fc43cb
] - (SEMVER-MINOR) fs: makedirent.path
writable (Antoine du Hamel) #5554725b1422337
] - (SEMVER-MINOR) http: add diagnostic channelhttp.client.request.created
(Marco Ippolito) #55586adda37f00c
] - (SEMVER-MINOR) module: addfindPackageJSON
util (Jacob Smith) #5541269dd1e13c3
] - (SEMVER-MINOR) module: add module.stripTypeScriptTypes (Marco Ippolito) #552828fc962f1af
] - tools: fix root certificate updater (Richard Lau) #55681Commits
9dbb255efb
] - assert: fixdeepStrictEqual
on errors whencause
is not undefined (Edigleysson Silva (Edy)) #554067af76ef0b3
] - assert: fix the string length check for printing the simple diff (Giovanni Bucci) #5547434483a299b
] - benchmark: add nodeTiming.uvmetricsinfo bench (RafaelGSS) #55614b79e4835ab
] - build: use rclone instead of aws CLI (Michaël Zasso) #556177ab1f46b8a
] - build: stop pre-compilinglint-md
(Aviv Keller) #552664887214e23
] - build: fix building with system icu 76 (Michael Cho) #55563f8df27aa5a
] - build: fix GN arg used in generate_config_gypi.py (Shelley Vohr) #55530bb78904548
] - build: fix GN build for sqlite and nghttp2 (Shelley Vohr) #55529535f1b0d4c
] - crypto: update root certificates to NSS 3.104 (Richard Lau) #556819b351b0749
] - crypto: fixRSA_PKCS1_PADDING
error message (Richard Lau) #556294b192daac0
] - deps: update acorn to 8.14.0 (Node.js GitHub Bot) #55699dfb764cbc6
] - deps: update sqlite to 3.47.0 (Node.js GitHub Bot) #555573477492588
] - deps: update amaro to 0.2.0 (Node.js GitHub Bot) #556013a1d490535
] - deps: update nghttp2 to 1.64.0 (Node.js GitHub Bot) #5555950552fdc92
] - deps: update acorn to 8.13.0 (Node.js GitHub Bot) #555581b82013f06
] - deps: update undici to 6.20.1 (Node.js GitHub Bot) #5550309060045b1
] - dns: stop using deprecatedares_query
(Aviv Keller) #554302d0914f337
] - doc: consolidate history table ofCustomEvent
(Edigleysson Silva) #55758cbe09b579f
] - doc: add path aliases typescript doc (Carlos Espa) #5576689aa83842a
] - doc: add esm example inpath.md
(Aviv Keller) #55745ee12431298
] - doc: consistent use of word child process (Gireesh Punathil) #5565420cb52d1d8
] - doc: clarity to available addon options (Preveen P) #55715bffbaa13a2
] - doc: update--max-semi-space-size
description (Joe Bowbeer) #55495505ff199b6
] - doc: brokenPerformanceObserver
code sample (Dom Harrington) #54227b8ca9d89f4
] - doc: add write flag when open file as the demo code's intention (robberfree) #546266662752b62
] - doc: add a note on console stream behavior (Gireesh Punathil) #556169743fa44ed
] - doc: remove mention of ECDH-ES in crypto.diffieHellman (Filip Skokan) #556115de2567644
] - doc: improve c++ embedder API doc (Gireesh Punathil) #55597f355054ec7
] - doc: capitalize "MIT License" (Aviv Keller) #55575fa61dced44
] - doc: move typescript support to active development (Marco Ippolito) #55536f77bf65059
] - doc: add suggested tsconfig for type stripping (Marco Ippolito) #55534f00ad27132
] - doc: add esm examples to node:string_decoder (Alfredo González) #555079dcca5441b
] - doc: add jazelly to collaborators (Jason Zhang) #55531f628fc43cb
] - (SEMVER-MINOR) fs: makedirent.path
writable (Antoine du Hamel) #55547dd9b6833c7
] - Revert "fs,win: fix bug in paths with trailing slashes" (Rod Vagg) #555278d0526f1f4
] - http: add diagnostic channelhttp.server.response.created
(Marco Ippolito) #5562225b1422337
] - (SEMVER-MINOR) http: add diagnostic channelhttp.client.request.created
(Marco Ippolito) #55586f92f20b930
] - http: don't emit error after destroy (Robert Nagy) #55457137aa5c9f6
] - http2: fix client async storage persistence (Orgad Shaneh) #55460d1965f9f5b
] - lib: implement webidl dictionary converter and use it in structuredClone (Jason Zhang) #55489bf552fa3cc
] - lib: prefer number to string in webidltype
function (Jason Zhang) #554897bfd295416
] - meta: bump actions/setup-python from 5.2.0 to 5.3.0 (dependabot[bot]) #5568821e3b7b2f4
] - meta: bump actions/setup-node from 4.0.4 to 4.1.0 (dependabot[bot]) #556872ae8d3b2ff
] - meta: bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2 (dependabot[bot]) #5568642e6c47086
] - meta: bump actions/upload-artifact from 4.4.0 to 4.4.3 (dependabot[bot]) #556859042e9acc9
] - meta: bump actions/cache from 4.0.2 to 4.1.2 (dependabot[bot]) #556845c2e4729cc
] - meta: bump actions/checkout from 4.2.0 to 4.2.2 (dependabot[bot]) #55683d79c8bf7a1
] - meta: bump github/codeql-action from 3.26.10 to 3.27.0 (dependabot[bot]) #55682d0ea9815f6
] - meta: make review-wanted message minimal (Aviv Keller) #55607b1ca7ab0a1
] - meta: show PR/issue title on review-wanted (Aviv Keller) #5560619b1edfc5c
] - module: simplify --inspect-brk handling (Joyee Cheung) #55679869e88c6a8
] - module: simplifyfindPackageJSON
implementation (Antoine du Hamel) #5554356c46ab686
] - module: unify TypeScript and .mjs handling in CommonJS (Joyee Cheung) #55590d3be3da6f8
] - module: fix error thrown from require(esm) hitting TLA repeatedly (Joyee Cheung) #55520b3971bbf13
] - module: trim off internal stack frames for require(esm) warnings (Joyee Cheung) #55496a9e08cfe6d
] - module: allow ESM that failed to be required to be re-imported (Joyee Cheung) #55502adda37f00c
] - (SEMVER-MINOR) module: addfindPackageJSON
util (Jacob Smith) #5541269dd1e13c3
] - (SEMVER-MINOR) module: add module.stripTypeScriptTypes (Marco Ippolito) #552826ab59c81b6
] - os: improve path check with direct index access (Mert Can Altin) #55434038ac01d26
] - path,win: fix bug in resolve and normalize (Hüseyin Açacak) #556237aa250afda
] - sqlite: improve error handling using MaybeLocal (Tobias Nießen) #555712ec4ae7c16
] - sqlite: add readOnly option (Tobias Nießen) #5556788c7f5b489
] - sqlite: refactor open options (Tobias Nießen) #554427853462a61
] - src: provide workaround for container-overflow (Daniel Lemire) #555910302efe4b2
] - src: move more key related stuff to ncrypto (James M Snell) #55368d26dedf41d
] - src: refactor ECDHBitsJob signature (Filip Skokan) #556104c34891454
] - src: fix dns crash when failed to create NodeAresTask (theanarkh) #55521467618418a
] - src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT (Charles Kerr) #55581016baaebbe
] - src: do not run IsWindowsBatchFile on non-windows (Yagiz Nizipli) #55560efa142c108
] - src: migrateString::Value
toString::ValueView
(Aviv Keller) #55458cfa4d960c8
] - src,lib: optimize nodeTiming.uvMetricsInfo (RafaelGSS) #5561419da4de475
] - test: updateperformance-timeline
wpt (RedYetiDev) #5519710b68ed975
] - test: ignore unrelated events in FW watch tests (Carlos Espa) #556057d93c0c3ae
] - test: refactor some esm tests (Antoine du Hamel) #55472815e2524a6
] - test: split up test-runner-mock-timers test (Julian Gassner) #555066aa797de4e
] - test: remove unneeded listeners (Luigi Pinca) #55486649d767a40
] - test: increase coverage ofpathToFileURL
(Antoine du Hamel) #5549371cc20a3a5
] - test: avoidapply()
calls with large amount of elements (Livia Medeiros) #555012d19614020
] - test: increase test coverage forhttp.OutgoingMessage.appendHeader()
(Juan José) #55467aebf676569
] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #5570353a7d8e75b
] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #555120ea74f3d02
] - test,crypto: make crypto tests work with BoringSSL (Shelley Vohr) #554913234dc6100
] - test_runner: passoptions
directly toTestCoverage
(Aviv Keller) #5557815028dd073
] - tools: update ESLint to 9.14.0 (dependabot[bot]) #55689961cbc9c0f
] - tools: useutil.parseArgs
inlint-md
(Aviv Keller) #556948fc962f1af
] - tools: fix root certificate updater (Richard Lau) #55681d0b2d6be84
] - tools: compact jq output in daily-wpt-fyi.yml action (Filip Skokan) #55695cba05cda38
] - tools: run daily WPT.fyi report on all supported releases (Filip Skokan) #556197ce7eab324
] - tools: lint README lists more strictly (Antoine du Hamel) #55625c2fcda45ca
] - typings: fixModulesBinding
types (Antoine du Hamel) #555492b9928561d
] - url: refactorpathToFileURL
to native (Antoine du Hamel) #554764129bc72e2
] - util: do not catch on circular@@toStringTag
errors (Aviv Keller) #55544