test: update `FileAPI` wpt #55194

RedYetiDev · 2024-09-30T19:39:49Z

`git node wpt FileAPI`

Note one new failure:
Passing a Float16Array as element of the blobParts array should work.

Note that several tests now pass that previously failed.

nodejs-github-bot · 2024-09-30T19:39:54Z

Review requested:

@nodejs/web-standards

codecov · 2024-10-01T00:59:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (89a2f56) to head (b1c015c).
Report is 195 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55194      +/-   ##
==========================================
+ Coverage   88.39%   88.40%   +0.01%     
==========================================
  Files         652      652              
  Lines      186565   186565              
  Branches    36046    36038       -8     
==========================================
+ Hits       164916   164936      +20     
+ Misses      14908    14902       -6     
+ Partials     6741     6727      -14

see 22 files with indirect coverage changes

nodejs-github-bot · 2024-10-18T10:42:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63173/

aduh95 · 2024-10-22T07:17:42Z

Seemingly related test failures:

    [EXPECTED_FAILURE][FAIL] Getters and value conversions should happen in order until an exception is thrown.
    assert_array_equals: lengths differ, expected array ["Symbol.iterator", "length getter", "length valueOf", "0 getter", "0 toString", "length getter", "length valueOf", "1 getter"] length 8, got ["Symbol.iterator", "Symbol.iterator", "length getter", "length valueOf", "0 getter", "0 toString", "length getter", "length valueOf", "1 getter"] length 9
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:179:3)
        at Test.step (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:2599:25)
        at test (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:628:30)
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:142:1
        at Script.runInThisContext (node:vm:137:12)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
    [PASS] ToString should be called on elements of the blobParts array and any exceptions should be propagated.
    [EXPECTED_FAILURE][FAIL] options properties should be accessed in lexicographic order.
    assert_array_equals: expected property 0 to be "endings" but got "type" (expected array ["endings", "type"] got ["type", "endings"])
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:398:3)
        at Test.step (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:2599:25)
        at test (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:628:30)
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:386:1
        at Script.runInThisContext (node:vm:137:12)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
    [EXPECTED_FAILURE][FAIL] Arguments should be evaluated from left to right.
    assert_unreached: type getter should not be called. Reached unreachable code
        at get type (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:407:22)
        at new Blob (node:internal/blob:152:7)
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js:404:5
        at assert_throws_exactly_impl (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:2332:18)
        at assert_throws_exactly (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/resources/testharness.js:2319:9)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
    [PASS] Passing 123 for options should throw
    [PASS] Passing 123.4 for options should throw
    [PASS] Passing true for options should throw
    [PASS] Passing "abc" for options should throw
    [PASS] Blob with type ""
    [PASS] Blob with type "a"
    [PASS] Blob with type "A"
    [PASS] Blob with type "text/html"
    [PASS] Blob with type "TEXT/HTML"
    [PASS] Blob with type "text/plain;charset=utf-8"
    [PASS] Blob with type "å"
    [PASS] Blob with type "𐑾"
    [PASS] Blob with type " image/gif "
    [PASS] Blob with type "\timage/gif\t"
    [PASS] Blob with type "image/gif;�"
    [PASS] Blob with type "İmage/gif"
    [PASS] Blob with type "ımage/gif"
    [PASS] Blob with type "image/gif\0"
    [PASS] Blob with type "unknown/unknown"
    [PASS] Blob with type "text/plain"
    [PASS] Blob with type "image/png"
    [PASS] A plain object with @@iterator should be treated as a sequence for the blobParts argument.
    [PASS] A plain object with @@iterator and a length property should be treated as a sequence for the blobParts argument.
    [PASS] A String object should be treated as a sequence for the blobParts argument.
    [PASS] A Uint8Array object should be treated as a sequence for the blobParts argument.
    [PASS] Changes to the blobParts array should be reflected in the returned Blob (pop).
    [PASS] Changes to the blobParts array should be reflected in the returned Blob (unshift).
    [PASS] ToString should be called on elements of the blobParts array.
    [PASS] ArrayBuffer elements of the blobParts array should be supported.
    [UNEXPECTED_FAILURE][FAIL] Passing typed arrays as elements of the blobParts array should work.
    assert_equals: expected "PASSPASSPASSPASSPASSPASSPASS" but got "PASSPASSAPSSAPSSSSAPSSAPSSAP"
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/support/Blob.js:16:5)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
    [EXPECTED_FAILURE][FAIL] Passing a Float16Array as element of the blobParts array should work.
    promise_test: Unhandled rejection with value: object "ReferenceError: Float16Array is not defined"
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
    [UNEXPECTED_FAILURE][FAIL] Passing a Float64Array as element of the blobParts array should work.
    assert_equals: expected "PASSPASS" but got "SSAPSSAP"
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/support/Blob.js:16:5)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'

RedYetiDev · 2024-10-24T21:28:40Z

I can't reproduce the failures locally

richardlau · 2024-10-24T22:38:50Z

Removing [EXPECTED_FAILURE] and [PASS]:

Seemingly related test failures:

    [UNEXPECTED_FAILURE][FAIL] Passing typed arrays as elements of the blobParts array should work.
    assert_equals: expected "PASSPASSPASSPASSPASSPASSPASS" but got "PASSPASSAPSSAPSSSSAPSSAPSSAP"
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/support/Blob.js:16:5)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'
    
...
    
    [UNEXPECTED_FAILURE][FAIL] Passing a Float64Array as element of the blobParts array should work.
    assert_equals: expected "PASSPASS" but got "SSAPSSAP"
        at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/fixtures/wpt/FileAPI/support/Blob.js:16:5)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    Command: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node  /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/wpt/test-blob.js 'Blob-constructor.any.js'

These look very much like endianness issues, especially since they're failing on AIX and LinuxONE which are both big endian platforms.

RedYetiDev · 2024-10-25T22:09:46Z

I don't have a big endian machine to test this one, but it's likely, there may be a bug 🤔. Drafting until whatever this is is resolved.

richardlau · 2024-10-31T19:18:04Z

I don't have a big endian machine to test this one, but it's likely, there may be a bug 🤔. Drafting until whatever this is is resolved.

I think it's a bug in WPT. Taking, for example,

node/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js

Lines 285 to 299 in b1c015c

    
           test_blob(function() { 
        
             return new Blob([ 
        
               new Uint8Array([0x50, 0x41, 0x53, 0x53]), 
        
               new Int8Array([0x50, 0x41, 0x53, 0x53]), 
        
               new Uint16Array([0x4150, 0x5353]), 
        
               new Int16Array([0x4150, 0x5353]), 
        
               new Uint32Array([0x53534150]), 
        
               new Int32Array([0x53534150]), 
        
               new Float32Array([0xD341500000]) 
        
             ]); 
        
           }, { 
        
             expected: "PASSPASSPASSPASSPASSPASSPASS", 
        
             type: "", 
        
             desc: "Passing typed arrays as elements of the blobParts array should work." 
        
           });

Typed arrays are by definition

Typed arrays always use the platform's native byte order.

which means, e.g. that the bytes for new Uint16Array([0x4150, 0x5353]) will be different on little endian vs big endian platforms.

KhafraDev · 2024-10-31T19:39:40Z

This is a bug in node. I will give some more context in a little bit.

KhafraDev · 2024-11-01T22:50:53Z

I forgot to follow up, but here are the steps (this follows through multiple specs so I will link each one).

The Blob constructor calls process blob parts.
process blob parts calls get a copy of the bytes held by the buffer source
which calls GetValueFromBuffer for each element in a webidl BufferSource (a TypedArray, DataView, or ArrayBuffer)
which calls RawBytesToNumeric (note the isLittleEndian flag
which is where we FINALLY get the step

If isLittleEndian is false, reverse the order of the elements of rawBytes.

RedYetiDev · 2024-11-03T11:39:03Z

Thanks for the details! I'll update these files later today, and if this is still the case, I'll open an issue in the WPT repository

richardlau · 2024-11-03T13:17:52Z

Thanks for the details! I'll update these files later today, and if this is still the case, I'll open an issue in the WPT repository

@KhafraDev 's analysis is that this is a Node.js bug, not a WPT one.

RedYetiDev · 2024-11-03T16:47:41Z

Oh, I misunderstood. Got it, keeping this is a draft until that's fixed

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 30, 2024

RedYetiDev added 2 commits September 30, 2024 19:28

test: update FileAPI wpt

96785dc

fixup! test: update FileAPI wpt

b1c015c

RedYetiDev force-pushed the upadate-wpt-fileapi branch from adcda63 to b1c015c Compare September 30, 2024 23:29

RedYetiDev mentioned this pull request Oct 17, 2024

test,crypto: update WebCryptoAPI WPT #55427

Merged

panva approved these changes Oct 18, 2024

View reviewed changes

RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2024

RedYetiDev marked this pull request as draft October 25, 2024 22:09

RedYetiDev added wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: update `FileAPI` wpt #55194

test: update `FileAPI` wpt #55194

RedYetiDev commented Sep 30, 2024

nodejs-github-bot commented Sep 30, 2024

codecov bot commented Oct 1, 2024 •

edited

Loading

nodejs-github-bot commented Oct 18, 2024

aduh95 commented Oct 22, 2024

RedYetiDev commented Oct 24, 2024

richardlau commented Oct 24, 2024

RedYetiDev commented Oct 25, 2024

richardlau commented Oct 31, 2024 •

edited

Loading

KhafraDev commented Oct 31, 2024

KhafraDev commented Nov 1, 2024

RedYetiDev commented Nov 3, 2024

richardlau commented Nov 3, 2024

RedYetiDev commented Nov 3, 2024

test: update FileAPI wpt #55194

Are you sure you want to change the base?

test: update FileAPI wpt #55194

Conversation

RedYetiDev commented Sep 30, 2024

git node wpt FileAPI

nodejs-github-bot commented Sep 30, 2024

codecov bot commented Oct 1, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Oct 18, 2024

aduh95 commented Oct 22, 2024

RedYetiDev commented Oct 24, 2024

richardlau commented Oct 24, 2024

RedYetiDev commented Oct 25, 2024

richardlau commented Oct 31, 2024 • edited Loading

KhafraDev commented Oct 31, 2024

KhafraDev commented Nov 1, 2024

RedYetiDev commented Nov 3, 2024

richardlau commented Nov 3, 2024

RedYetiDev commented Nov 3, 2024

test: update `FileAPI` wpt #55194

test: update `FileAPI` wpt #55194

`git node wpt FileAPI`

codecov bot commented Oct 1, 2024 •

edited

Loading

richardlau commented Oct 31, 2024 •

edited

Loading