-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,crypto: update WebCryptoAPI WPT #55427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
Issues and PRs related to the crypto subsystem.
test
Issues and PRs related to the tests.
webcrypto
labels
Oct 17, 2024
Review requested:
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 17, 2024
lpinca
approved these changes
Oct 17, 2024
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55427 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 652 653 +1
Lines 186918 187604 +686
Branches 36072 36115 +43
==========================================
+ Hits 165270 165862 +592
- Misses 14891 14963 +72
- Partials 6757 6779 +22 |
mertcanaltin
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anonrig
approved these changes
Oct 19, 2024
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2024
Landed in 7d0a490 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55427 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55427 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55427 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
web-standards
Issues and PRs related to Web APIs
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just
git node wpt WebCryptoAPI