build: update Node.js logo on OSX installer #5401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe /cc @nodejs/website and @nodejs/documentation as those groups are most concerned with UX? Also see #5391 for the Windows one where we have different constraints. |
|
Also, for anyone who wants to tinker with this, you can build it off master with |
mscdex
added
install
|
Optimized: |
rvagg
force-pushed
the
osx-installer-new-logo
branch
from
a251b67
to
c123044
Compare
|
thanks, updated, 5138b vs 6576b |
|
The left side should be aligned with the bullet points of the installer menu (see the Silverlight example) and the right side should have roughly the same space. |
|
Thanks @fhemberger, that's the kind of feedback I needed. How does this one look? I'm dividing up the vertical space under "Summary" and the bottom of main the content box to find vertical position, does that look OK?
|
|
It may look better if the logo is moved lower such that the whitespace between the logo's bottom and the bottom edge of the dialog is similar to that of the whitespace between the word "Introduction" and the top of edge of the dialog. |
|
That would look like this:
(I have no opinions at this point, just tell me what to do) |
|
Latest iteration LGTM. |
|
LGTM. |
|
LGTM as well |
|
Here's an actual running version of the latest, not just a mockup
|
rvagg
force-pushed
the
osx-installer-new-logo
branch
from
c123044
to
b07e334
Compare
|
LGTM |
|
Though I get the feeling that the Logo is detached from the text, LGTM. |
|
thanks all, 2ccc275 |
rvagg
added a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
added a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
added a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
added a commit
that referenced
this pull request
Mar 3, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
added a commit
that referenced
this pull request
Mar 3, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
added a commit
that referenced
this pull request
Mar 3, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
@rvagg is this ready to get back ported for the next LTS or should we wait a bit? |
|
@thealphanerd it's already in 0.10 and 0.12 so should be in v4.x too |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select you VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
MylesBorins
pushed a commit
that referenced
this pull request
Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
MylesBorins
pushed a commit
that referenced
this pull request
Mar 22, 2016
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
PR-URL: #5835
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Jun 8, 2016
PR-URL: nodejs#5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
PR-URL: nodejs/node#5401 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5381 for OSX, this change would be backported all the way back to v0.10. Going forward we would need a new design for the new Packages-based installer along with, or after #2571 but that would (likely) only apply to v5+.
Current installer:
With this PR
Happy to take feedback on size and spacing and whatever else. Basically we get to play with the entire background of this window as a transparent png, you can even get dramatic as Microsoft does for example (not executed perfectly and perhaps this points to OSX and/or pkg variances).