-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, installer: win - new logo in installer #5391
doc, installer: win - new logo in installer #5391
Conversation
Could these be @eljefedelrodeodeljefe Could you ensure that these are run though tools like imageoptim to reduce their size as much as possible (while keeping quality)? |
I've got several high res versions of the logo, we're working to get the downloads page on the website updated with them. You'll see them posted here soon nodejs/nodejs.org#526 (comment) |
@Fishrock123 can do it in @mikeal took the vector formats out of the |
saved 20% space, output looks good to me still. |
I'm pretty sure we've had problems with trying to do .png in the past, I'll push out a test build as soon as we have Jenkins back /cc @nodejs/platform-windows |
@eljefedelrodeodeljefe the last post on http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/BMP-and-JPEG-td3503935.html suggests compressed indexed |
revert to jpg extension
Sorry. Didn't mean to close. Did a mistake rebasing. |
Description of change
Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test
(UNIX) orvcbuild test nosign
(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open.
Affected core subsystem(s)
none