Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, installer: win - new logo in installer #5391

Closed
wants to merge 1 commit into from
Closed

doc, installer: win - new logo in installer #5391

wants to merge 1 commit into from

Conversation

eljefedelrodeodeljefe
Copy link
Contributor

Description of change

Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open.

Affected core subsystem(s)

none

@mscdex mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Feb 23, 2016
@Fishrock123
Copy link
Contributor

Could these be .png? I think there was maybe a windows issue about that?

@eljefedelrodeodeljefe Could you ensure that these are run though tools like imageoptim to reduce their size as much as possible (while keeping quality)?

@mikeal
Copy link
Contributor

mikeal commented Feb 23, 2016

I've got several high res versions of the logo, we're working to get the downloads page on the website updated with them. You'll see them posted here soon nodejs/nodejs.org#526 (comment)

@eljefedelrodeodeljefe
Copy link
Contributor Author

@Fishrock123 can do it in .png, would be a change from .jpg though. I ran it from Adobe Illustrator / Photoshop. But will try to optimise further with something like it.

@mikeal took the vector formats out of the .pdf https://drive.google.com/folderview?id=0B2SAGsHi4DjIcHB0cTZZcXFZNG8&usp=sharing

@eljefedelrodeodeljefe
Copy link
Contributor Author

saved 20% space, output looks good to me still.

@rvagg
Copy link
Member

rvagg commented Feb 24, 2016

I'm pretty sure we've had problems with trying to do .png in the past, I'll push out a test build as soon as we have Jenkins back

/cc @nodejs/platform-windows

@joaocgreis
Copy link
Member

.png is a problem for Windows 7 / 2008, according to MSDN it is only supported on Windows 8 and after. I confirmed it, the installer appears with a gray background.

@eljefedelrodeodeljefe the last post on http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/BMP-and-JPEG-td3503935.html suggests compressed indexed .bmp, you could give it a try, or just use .jpg.

@eljefedelrodeodeljefe
Copy link
Contributor Author

Sorry. Didn't mean to close. Did a mistake rebasing. Will push in a minute. referenced new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants