test: increase timeouts on some unref timers tests #5352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
force-pushed
the
increase-unref-timeouts
branch
from
fdcabf4
to
40a93ad
Compare
|
LGTM |
mscdex
added
the
timers
|
LGTM |
1 similar comment
|
LGTM |
|
guess I should probably run the CI: https://ci.nodejs.org/job/node-test-pull-request/1722/ |
Fishrock123
added a commit
that referenced
this pull request
Feb 22, 2016
Fix: #5351 Refs: #4561 PR-URL: #5352 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Fishrock123
force-pushed
the
increase-unref-timeouts
branch
from
40a93ad
to
65cd2a0
Compare
|
landed in 65cd2a0 |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Fix: #5351 Refs: #4561 PR-URL: #5352 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Fix: #5351 Refs: #4561 PR-URL: #5352 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fix: #5351 Refs: #4561 PR-URL: #5352 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5351
Refs: #4561
PR-URL: #5352
After #4007 lands we should consider replacing some of these tests with refed versions since they will take the same codepath.
Or add something where we can tell it to just use refed handles.