net: fix error details in connect() #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ac4941 introduced a slight bug in the improved error messages.
| @@ -788,7 +789,7 @@ function connect(self, address, port, addressType, localAddress, localPort) { | |||
| err = bind(localAddress, localPort); | |||
|
|
|||
| if (err) { | |||
| var ex = exceptionWithHostPort(err, 'bind', localAddress, localPort); | |||
| ex = exceptionWithHostPort(err, 'bind', localAddress, localPort); | |||
There was a problem hiding this comment.
Declaring the var upfront is not really necessary (it gets hoisted anyway) and it makes the diff more noisy than it really needs to be.
|
LGTM but the commit log would be better if it explained what the bug was. Can you add a |
|
Sure thing. I assumed that would be added in with the other commit metadata. |
cjihrig
added a commit
that referenced
this pull request
Jan 19, 2015
3ac4941 introduced a bug as it attempted to access properties of an undefined variable. This commit cleans up the offending code. Fixes: #510 PR-URL: #514 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Ben. Addressed your comments and landed in e2558f0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3ac4941 introduced a slight bug in the improved error messages. Closes #510