Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError from net.js #510

Closed
karlbohlmark opened this issue Jan 19, 2015 · 3 comments
Closed

TypeError from net.js #510

karlbohlmark opened this issue Jan 19, 2015 · 3 comments

Comments

@karlbohlmark
Copy link

This looks like an error that shouldn't be surfaced to the user:

net.js:819
      ex.localAddress = self._sockname.address;
                      ^
TypeError: Cannot set property 'localAddress' of undefined
    at connect (net.js:819:23)
    at net.js:922:9
    at GetAddrInfoReqWrap.asyncCallback [as callback] (dns.js:62:16)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:80:10)

Using io.js v1.0.2.

Not present in node v0.11.14
@rvagg
Copy link
Member

rvagg commented Jan 19, 2015

summoning @evanlucas from #35

@cjihrig cjihrig mentioned this issue Jan 19, 2015
Closed
@evanlucas
Copy link
Contributor

ah looks like @cjihrig got to it first.

cjihrig added a commit that referenced this issue Jan 19, 2015
@cjihrig
net: fix error details in connect()
e2558f0 
3ac4941 introduced a
bug as it attempted to access properties of an
undefined variable. This commit cleans up the offending
code.

Fixes: #510
PR-URL: #514
Reviewed-By: Ben Noordhuis <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented Jan 19, 2015

Fixed in e2558f0

@cjihrig cjihrig closed this as completed Jan 19, 2015
@kevinsawicki kevinsawicki mentioned this issue Feb 9, 2015
Closed
@tccki tccki mentioned this issue Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karlbohlmark @rvagg @evanlucas @cjihrig