[v20.x backport] snapshot test improvments

test/common/assertSnapshot.js

@@ -8,6 +8,10 @@ const assert = require('node:assert/strict');
 const stackFramesRegexp = /(?<=\n)(\s+)((.+?)\s+\()?(?:\(?(.+?):(\d+)(?::(\d+))?)\)?(\s+\{)?(\[\d+m)?(\n|$)/g;
 const windowNewlineRegexp = /\r/g;
 
+function replaceNodeVersion(str) {
+  return str.replaceAll(process.version, '*');
+}
+
 function replaceStackTrace(str, replacement = '$1*$7$8\n') {
   return str.replace(stackFramesRegexp, replacement);
 }
@@ -84,6 +88,7 @@ module.exports = {
   assertSnapshot,
   getSnapshotPath,
   replaceFullPaths,
+  replaceNodeVersion,
   replaceStackTrace,
   replaceWindowsLineEndings,
   replaceWindowsPaths,

test/message/core_line_numbers.js → test/fixtures/errors/core_line_numbers.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 3;
 
 const punycode = require('punycode');

test/message/core_line_numbers.out → test/fixtures/errors/core_line_numbers.snapshot

@@ -4,7 +4,7 @@ node:punycode:52
 
 RangeError: Invalid input
     at error (node:punycode:52:8)
-    at Object.decode (node:punycode:*:*)
-    at Object.<anonymous> (*test*message*core_line_numbers.js:*:*)
+    at Object.decode (node:punycode:245:5)
+    at Object.<anonymous> (*core_line_numbers.js:13:10)
 
 Node.js *

test/fixtures/errors/force_colors.snapshot

@@ -4,11 +4,11 @@ throw new Error('Should include grayed stack trace')
 
 Error: Should include grayed stack trace
     at Object.<anonymous> (/test*force_colors.js:1:7)
-    at Module._compile (node:internal*modules*cjs*loader:1241:14)
-    at Module._extensions..js (node:internal*modules*cjs*loader:1295:10)
-    at Module.load (node:internal*modules*cjs*loader:1091:32)
-    at Module._load (node:internal*modules*cjs*loader:938:12)
-    at Function.executeUserEntryPoint [as runMain] (node:internal*modules*run_main:83:12)
-    at node:internal*main*run_main_module:23:47
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
 
 Node.js *

test/message/if-error-has-good-stack.js → test/fixtures/errors/if-error-has-good-stack.js

@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 4;
 
 const assert = require('assert');

test/message/if-error-has-good-stack.out → test/fixtures/errors/if-error-has-good-stack.snapshot

@@ -3,7 +3,7 @@ node:assert:*
     ^
 
 AssertionError [ERR_ASSERTION]: ifError got unwanted exception: test error
-    at z (*if-error-has-good-stack.js:*:*
+    at z (*if-error-has-good-stack.js:*:*)
     at y (*if-error-has-good-stack.js:*:*)
     at x (*if-error-has-good-stack.js:*:*)
     at Object.<anonymous> (*if-error-has-good-stack.js:*:*)

test/message/promise_unhandled_warn_with_error.js → test/fixtures/errors/promise_unhandled_warn_with_error.js

@@ -1,7 +1,7 @@
 // Flags: --unhandled-rejections=warn-with-error-code
 'use strict';
 
-require('../common');
+require('../../common');
 const assert = require('assert');
 
 Promise.reject(new Error('alas'));

test/fixtures/errors/promise_unhandled_warn_with_error.snapshot

@@ -0,0 +1,10 @@
+(node:*) UnhandledPromiseRejectionWarning: Error: alas
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+(Use `node --trace-warnings ...` to show where the warning was created)
+(node:*) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https:*nodejs.org*api*cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

test/message/test-no-extra-info-on-fatal-exception.js → test/fixtures/errors/test-no-extra-info-on-fatal-exception.js

@@ -1,7 +1,7 @@
 // Flags: --no-extra-info-on-fatal-exception
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 1;
 
 throw new Error('foo');

test/fixtures/errors/test-no-extra-info-on-fatal-exception.snapshot

@@ -0,0 +1,6 @@
+*test-no-extra-info-on-fatal-exception.js:7
+throw new Error('foo');
+^
+
+Error: foo
+    at Object.<anonymous> (*test-no-extra-info-on-fatal-exception.js:7:7)

test/message/throw_error_with_getter_throw.js → test/fixtures/errors/throw_error_with_getter_throw.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+require('../../common');
 throw {  // eslint-disable-line no-throw-literal
   get stack() {
     throw new Error('weird throw but ok');

test/fixtures/errors/throw_error_with_getter_throw.snapshot

@@ -0,0 +1,8 @@
+
+*throw_error_with_getter_throw.js:*
+throw {  * eslint-disable-line no-throw-literal
+^
+[object Object]
+(Use `node --trace-uncaught ...` to show where the exception was thrown)
+
+Node.js *

test/message/throw_null.js → test/fixtures/errors/throw_null.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 // eslint-disable-next-line no-throw-literal
 throw null;

test/fixtures/errors/throw_null.snapshot

@@ -0,0 +1,8 @@
+
+*throw_null.js:*
+throw null;
+^
+null
+(Use `node --trace-uncaught ...` to show where the exception was thrown)
+
+Node.js *

test/message/throw_undefined.js → test/fixtures/errors/throw_undefined.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 // eslint-disable-next-line no-throw-literal
 throw undefined;

test/fixtures/errors/throw_undefined.snapshot

@@ -0,0 +1,8 @@
+
+*throw_undefined.js:*
+throw undefined;
+^
+undefined
+(Use `node --trace-uncaught ...` to show where the exception was thrown)
+
+Node.js *

test/message/timeout_throw.js → test/fixtures/errors/timeout_throw.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 setTimeout(function() {
   // eslint-disable-next-line no-undef,no-unused-expressions

test/fixtures/errors/timeout_throw.snapshot

@@ -0,0 +1,10 @@
+*timeout_throw.js:*
+  undefined_reference_error_maker;
+  ^
+
+ReferenceError: undefined_reference_error_maker is not defined
+    at Timeout._onTimeout (*timeout_throw.js:*:*)
+    at listOnTimeout (node:internal*timers:*:*)
+    at process.processTimers (node:internal*timers:*:*)
+
+Node.js *

test/message/undefined_reference_in_new_context.js → test/fixtures/errors/undefined_reference_in_new_context.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 const vm = require('vm');
 
 console.error('before');

test/fixtures/errors/undefined_reference_in_new_context.snapshot

@@ -0,0 +1,13 @@
+before
+evalmachine.<anonymous>:*
+Error.stackTraceLimit = 5; foo.bar = 5;
+                           ^
+
+ReferenceError: foo is not defined
+    at evalmachine.<anonymous>:*:*
+    at Script.runInContext (node:vm:*:*)
+    at Script.runInNewContext (node:vm:*:*)
+    at Object.runInNewContext (node:vm:*:*)
+    at Object.<anonymous> (*undefined_reference_in_new_context.js:*:*)
+
+Node.js *

test/message/unhandled_promise_trace_warnings.js → test/fixtures/errors/unhandled_promise_trace_warnings.js

@@ -1,5 +1,5 @@
 // Flags: --trace-warnings --unhandled-rejections=warn
 'use strict';
-require('../common');
+require('../../common');
 const p = Promise.reject(new Error('This was rejected'));
 setImmediate(() => p.catch(() => {}));

test/fixtures/errors/unhandled_promise_trace_warnings.snapshot

@@ -0,0 +1,26 @@
+(node:*) UnhandledPromiseRejectionWarning: Error: This was rejected
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+(node:*) Error: This was rejected
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+    at *
+(node:*) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
+    at *
+    at *
+    at Promise.then (<anonymous>)
+    at Promise.catch (<anonymous>)
+    at *
+    at *

test/fixtures/source-map/output/source_map_sourcemapping_url_string.snapshot

@@ -1,3 +1,3 @@
 Error: an exception.
     at Object.<anonymous> (*typescript-sourcemapping_url_string.ts:3:7)
-    at Module._compile (node:internal*modules*cjs*loader:1241:14)
+    *