Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] snapshot test improvments #49942

Closed
wants to merge 2 commits into from
Closed

[v20.x backport] snapshot test improvments #49942

wants to merge 2 commits into from

Commits on Sep 28, 2023

  1. test: fix edge snapshot stack traces 

    PR-URL: nodejs#49659
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
    @GeoffreyBooth @MoLow
    GeoffreyBooth authored and MoLow committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    448b9cc View commit details
    Browse the repository at this point in the history

  2. test: migrate message error tests from Python to JS 

    Migrate the remaining error tests in the `test/message` folder
from Python to JS.

Fixes: nodejs#47707
PR-URL: nodejs#49721
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
    @MoLow
    Yiyun Lei authored and MoLow committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1c78bec View commit details
    Browse the repository at this point in the history