Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock-free init_process_flags for all archs #45221

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Oct 28, 2022

Fix #45152

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2022
src/node.cc Show resolved Hide resolved
src/node.h Outdated Show resolved Hide resolved
src/node.cc Show resolved Hide resolved
@kapouer kapouer force-pushed the patch-4 branch 2 times, most recently from 2fc42b0 to 1627557 Compare October 28, 2022 13:19
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

@kapouer
Copy link
Contributor Author

kapouer commented Oct 28, 2022

@addaleax changed TODO(addaleax) and wrapped line to 80 chars.

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3d1bdc9 into nodejs:main Oct 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3d1bdc9

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
Fix nodejs#45152

PR-URL: nodejs#45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2023
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2023
nodejs-github-bot pushed a commit that referenced this pull request Feb 2, 2023
Refs: #45221
PR-URL: #46427
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init_process_flags.is_lock_free check fails on mipsel
5 participants