src: lock-free init_process_flags

Fix #45152 PR-URL: #45221 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
nodejs · Dec 30, 2022 · 8247d10 · 8247d10
1 parent 8dd43d9
commit 8247d10
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -445,7 +445,7 @@ void ResetSignalHandlers() {
 #endif  // __POSIX__
 }
 
-static std::atomic<uint64_t> init_process_flags = 0;
+static std::atomic<uint32_t> init_process_flags = 0;
 
 static void PlatformInit(ProcessInitializationFlags::Flags flags) {
   // init_process_flags is accessed in ResetStdio(),

diff --git a/src/node.h b/src/node.h
@@ -228,6 +228,8 @@ class MultiIsolatePlatform;
 class InitializationResultImpl;
 
 namespace ProcessFlags {
+// TODO(addaleax): Switch to uint32_t to match std::atomic<uint32_t>
+// init_process_flags in node.cc
 enum Flags : uint64_t {
   kNoFlags = 0,
   // Enable stdio inheritance, which is disabled by default.