-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v16.x] deps: V8: cherry-pick d8dc66f #41566
Conversation
Review requested:
|
Reland #41564 @gengjiawen @targos |
@luyahan do you target v16.x-staging because the fixes are already in v17.x ? |
Yes. |
Original commit message: [riscv64][sparkplug] Fix sparkplug verify framesize failed Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009 Auto-Submit: Yahan Lu <[email protected]> Reviewed-by: Ji Qiu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/master@{#76277} Refs: v8/v8@d8dc66f9
Original commit message: [riscv64] Use s1 to save code_obj The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj. Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886 Reviewed-by: Ji Qiu <[email protected]> Commit-Queue: Ji Qiu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/master@{#76294} Refs: v8/v8@3cab84c2472
Original commit message: [riscv64] Link should greater and equal zero Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673 Commit-Queue: Yahan Lu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Reviewed-by: Ji Qiu <[email protected]> Cr-Commit-Position: refs/heads/main@{#76784} Refs: v8/v8@471f862954f3
Original commit message: [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#76296} Refs: v8/v8@e74d6918fb9
Original commit message: [riscv64] Add block before LoadAddress fix node.js DCHECK failed issue: riscv-collab/v8#514 Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979 Reviewed-by: ji qiu <[email protected]> Commit-Queue: ji qiu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/main@{#77750} Refs: v8/v8@77599ffe0a74
a4fb9ee
to
f18bb63
Compare
How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console? |
@luyahan Seems like a test case is failing: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/13158/console That's strange, because this PR does not mess up with those Windows stuff. |
You can ignore that one as it's a known flake #40728. The last CI (https://ci.nodejs.org/job/node-test-pull-request/41993/) passed. |
@luyahan @targos @richardlau what is the status of this? Does this need to be backported to include the base branch/PR metadata, or can we pull this into the next 16.x as is? |
@danielleadams the changes only apply to v16.x, so we should directly pull this into the next release. |
Original commit message: [riscv64][sparkplug] Fix sparkplug verify framesize failed Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009 Auto-Submit: Yahan Lu <[email protected]> Reviewed-by: Ji Qiu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/master@{#76277} Refs: v8/v8@d8dc66f9 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Original commit message: [riscv64] Use s1 to save code_obj The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj. Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886 Reviewed-by: Ji Qiu <[email protected]> Commit-Queue: Ji Qiu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/master@{#76294} Refs: v8/v8@3cab84c2472 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Original commit message: [riscv64] Link should greater and equal zero Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673 Commit-Queue: Yahan Lu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Reviewed-by: Ji Qiu <[email protected]> Cr-Commit-Position: refs/heads/main@{#76784} Refs: v8/v8@471f862954f3 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Original commit message: [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#76296} Refs: v8/v8@e74d6918fb9 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Original commit message: [riscv64] Add block before LoadAddress fix node.js DCHECK failed issue: riscv-collab/v8#514 Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979 Reviewed-by: ji qiu <[email protected]> Commit-Queue: ji qiu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/main@{#77750} Refs: v8/v8@77599ffe0a74 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Landed in 9e68c00...036650e |
Fix riscv64 segment fault
origin commit :
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff