Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real OS tmp dir on Linux for long path tests #3925

Closed
wants to merge 1 commit into from
Closed

Use real OS tmp dir on Linux for long path tests #3925

wants to merge 1 commit into from

Conversation

rsp
Copy link
Contributor

@rsp rsp commented Nov 19, 2015

Use os.tmpdir() on Linux if it is readable/writable
in test-fs-long-path.js and test-require-long-path.js
to avoid failing tests on ecryptfs filesystems - see issue #2255

Use os.tmpdir() on Linux if it is readable/writable
in test-fs-long-path.js and test-require-long-path.js
to avoid failing tests on ecryptfs filesystems - see issue #2255
@rvagg
Copy link
Member

rvagg commented Nov 19, 2015

I think the best way to do this would be to first try the original way and then do the /tmp/ thing if it fails. One of the primary problems I see with relying on the OS tmpdir is that it's usually a completely different fs than the rest of the system, on Linux anyway, most distros now use tmpfs for it, so anything done in there may not be quite the same as working on other parts of the fs.

Need some more input on this, @bnoordhuis perhaps? Got any suggestions?

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. labels Nov 19, 2015
@rsp
Copy link
Contributor Author

rsp commented Nov 19, 2015

@rvagg Thanks for the advice. I prepared a second PR #3929 that works in a way that you describe. It retries the tests under os.tempdir() but only if the original tests fail (and only on Linux).

@rsp
Copy link
Contributor Author

rsp commented Nov 19, 2015

@rvagg Re: tmpfs not being the same as the rest of the file ststem - yes, that's why it works. The test fails on Ubuntu not because Node is broken but because ecryptfs is, well, limited. If it fails under one file system it retries under another one and if it's ok then it means that it's not Node's fault. This test was introduced to test Windows anyway, and my PR doesn't use os.tmpdir() on Windows, only on Linux. Please let me know if it needs any other changes. Thanks.

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

Any updates on this one?

@rsp
Copy link
Contributor Author

rsp commented Mar 22, 2016

@jasnell I'm closing this one as well. See my comment in #3929.

@rsp rsp closed this Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. module Issues and PRs related to the module subsystem. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants