Skip the long path tests when not on Windows #4116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| if (process.platform !== 'win32') process.exit(); | |||
|
LGTM, thanks. Can you squash and write a commit log in the style that CONTRIBUTING.md wants? |
mscdex
added
fs
|
@bnoordhuis I rebased it on fresh master, squashed into e07b145 with new message and force pushed here. I can't access the CI link ("rsp is missing the Overall/Read permission") so I don't know if it tests the forced update automatically or not. Thanks for your help. |
|
LGTM |
|
As @rsp updated, new CI : https://ci.nodejs.org/job/node-test-pull-request/932/ |
|
LGTM if new CI is happy :) |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 7, 2015
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: #2255 PR-URL: #4116 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Thanks, landed in 19e06d7. |
rvagg
pushed a commit
that referenced
this pull request
Dec 8, 2015
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: #2255 PR-URL: #4116 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This was referenced Dec 8, 2015
|
@jasnell @JungMinu @bnoordhuis @rvagg Thanks. My pleasure. I think the |
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 29, 2015
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: #2255 PR-URL: #4116 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: #2255 PR-URL: #4116 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: nodejs#2255 PR-URL: nodejs#4116 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to fix the tests failing on Ubuntu (see issue #2255)
This time by skipping the tests when not on Windows (as advised by @bnoordhuis)
Other PRs that solve the same issue:
See also comments to PRs #3925 and #3929 for more context.