[v14.x backport] deps,debugger: move node-inspect into core #38858

Trott · 2021-05-30T18:56:34Z

Original pull request: #38161

Trott · 2021-05-30T18:56:42Z

Trott · 2021-05-30T18:57:57Z

I didn't compile or run tests locally but there was only one merge conflict that was straightforward to resolve, so I think it should work.

bl-ue

RSLGTM

node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: nodejs#36481 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Fixes: nodejs#37224 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

targos · 2021-05-30T20:35:19Z

I should have said that I already tried to fix the conflict and run tests, but got failures.

Trott · 2021-05-30T20:40:29Z

I should have said that I already tried to fix the conflict and run tests, but got failures.

Will Node.js 14 get V8 8.5 at some point?

targos · 2021-05-30T20:41:35Z

I should have said that I already tried to fix the conflict and run tests, but got failures.

Will Node.js 14 get V8 8.5 at some point?

No, that likely won't happen.

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: #36481 PR-URL: #38161 Backport-PR-URL: #38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Fixes: #37224 PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: nodejs#36481 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Fixes: nodejs#37224 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

github-actions bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v14.x labels May 30, 2021

Trott mentioned this pull request May 30, 2021

deps,debugger: move node-inspect into core #38161

Merged

bl-ue approved these changes May 30, 2021

View reviewed changes

Trott force-pushed the v14.x-backport-33161 branch from be8bef8 to 6f3662c Compare May 30, 2021 19:04

This comment has been minimized.

Sign in to view

richardlau mentioned this pull request Jul 19, 2021

test: fix flaky inspector-cli tests when breakpoints are restored #38431

Merged

Trott deleted the v14.x-backport-33161 branch September 25, 2022 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v14.x backport] deps,debugger: move node-inspect into core #38858

[v14.x backport] deps,debugger: move node-inspect into core #38858

Trott commented May 30, 2021 •

edited

Loading

Trott commented May 30, 2021

Trott commented May 30, 2021

bl-ue left a comment

This comment has been minimized.

targos commented May 30, 2021

Trott commented May 30, 2021

targos commented May 30, 2021

[v14.x backport] deps,debugger: move node-inspect into core #38858

[v14.x backport] deps,debugger: move node-inspect into core #38858

Conversation

Trott commented May 30, 2021 • edited Loading

Trott commented May 30, 2021

Trott commented May 30, 2021

bl-ue left a comment

Choose a reason for hiding this comment

This comment has been minimized.

targos commented May 30, 2021

Trott commented May 30, 2021

targos commented May 30, 2021

Trott commented May 30, 2021 •

edited

Loading