deps,debugger: move node-inspect into core #38161

Trott · 2021-04-09T07:05:42Z

I named a lot of files/directories with inspector-cli and I suspect inspect-cli or debugger-cli (or just debugger or inspect) would have all been better?

Still some ESLint checks to re-enable in three files, but assuming tests pass everywhere, I think this is good enough to land and things can be adjusted with subsequent PRs.

Because I was porting over the tests, this found and fixed a small bug with node inspect in Node.js 15.x. Specifically, calling scripts would always include internal scripts, even with scripts(false). (Wouldn't mind reconsidering that API as that first argument is a boolean trap. But OMG not when first landing this thing.)

Also there are some changes that landed in the node-inspect repo but never made it into a release. Those changes will need to be ported over. But that's the next PR. (Or maybe the lint fixes would be the next one.)

Trott · 2021-04-09T07:06:28Z

@nodejs/diagnostics

Trott · 2021-04-09T07:12:30Z

(Easier to review, I think, if you look at each commit separately.)

mcollina

lgtm

jkrems

Thanks so much for working on this!

Trott · 2021-04-11T04:50:00Z

Anyone know what the right thing to do with this failing test on sharedlibs_openssl300 might be?

https://ci.nodejs.org/job/node-test-commit-linux-containered/26443/nodes=ubuntu1804_sharedlibs_openssl300_x64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_auto_resume/

/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

@danbev

Trott · 2021-04-11T04:52:29Z

Getting a lot of ECONNRESET on Windows and wondering how I might make the tests more robust.

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/9309/#showFailuresLink

@nodejs/platform-windows

richardlau · 2021-04-11T06:44:59Z

Anyone know what the right thing to do with this failing test on sharedlibs_openssl300 might be?

https://ci.nodejs.org/job/node-test-commit-linux-containered/26443/nodes=ubuntu1804_sharedlibs_openssl300_x64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_auto_resume/
/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node: error while loading shared libraries: libcrypto.so.3: cannot open shared object file: No such file or directory

@Trott The test needs to pass on the environment when it spawns a child node process — specifically on Linux LD_LIBRARY_PATH needs to be passed on (other operating systems use different but equivalent variables that would need to be passed on if node is dynamically linked to a non-system shared library).

Trott · 2021-04-11T19:21:49Z

The failed tests in CI on Windows looks (superficially at least) like maybe it's #37224. Might be a significant legitimate bug seen in node-inspect + Node.js 15 + WIndows. Any ideas about how to best fix?

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: #36481 PR-URL: #38161 Backport-PR-URL: #38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Fixes: #37224 PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #38161 Backport-PR-URL: #38858 Refs: #36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: nodejs#36481 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Fixes: nodejs#37224 PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Change process.binding() use to internalBinding(). PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#38161 Backport-PR-URL: nodejs#38858 Refs: nodejs#36481 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 9, 2021

Trott changed the title ~~Node inspect~~ deps,debugger: move node-inspect into core Apr 9, 2021

Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 9, 2021

Trott requested a review from jkrems April 9, 2021 07:06

mcollina approved these changes Apr 9, 2021

View reviewed changes

Trott force-pushed the node-inspect branch from 7abbfed to dce5476 Compare April 9, 2021 13:49

jkrems approved these changes Apr 9, 2021

View reviewed changes

cjihrig approved these changes Apr 9, 2021

View reviewed changes

Trott force-pushed the node-inspect branch 2 times, most recently from 267e87c to 1069e36 Compare April 10, 2021 05:13

Qard approved these changes Apr 10, 2021

View reviewed changes

Trott force-pushed the node-inspect branch from d1647d4 to a85d5ad Compare April 10, 2021 22:11

This comment has been minimized.

Sign in to view

Trott force-pushed the node-inspect branch from a85d5ad to aef35b5 Compare April 11, 2021 00:59

This comment has been minimized.

Sign in to view

Trott force-pushed the node-inspect branch from e76f8bc to fdd596e Compare April 11, 2021 13:53

This comment has been minimized.

Sign in to view

Flarna approved these changes Apr 13, 2021

View reviewed changes

Trott force-pushed the node-inspect branch from 65ee417 to 83ac996 Compare April 16, 2021 09:45

targos added backported-to-v14.x and removed backport-open-v14.x labels Jul 16, 2021

richardlau mentioned this pull request Jul 20, 2021

v14.17.4 proposal #39466

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps,debugger: move node-inspect into core #38161

deps,debugger: move node-inspect into core #38161

Trott commented Apr 9, 2021

Trott commented Apr 9, 2021

Trott commented Apr 9, 2021

mcollina left a comment

jkrems left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Trott commented Apr 11, 2021

Trott commented Apr 11, 2021

This comment has been minimized.

richardlau commented Apr 11, 2021

This comment has been minimized.

Trott commented Apr 11, 2021 •

edited

Loading

deps,debugger: move node-inspect into core #38161

deps,debugger: move node-inspect into core #38161

Conversation

Trott commented Apr 9, 2021

Trott commented Apr 9, 2021

Trott commented Apr 9, 2021

mcollina left a comment

Choose a reason for hiding this comment

jkrems left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Trott commented Apr 11, 2021

Trott commented Apr 11, 2021

This comment has been minimized.

richardlau commented Apr 11, 2021

This comment has been minimized.

Trott commented Apr 11, 2021 • edited Loading

Trott commented Apr 11, 2021 •

edited

Loading