Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12 backport] ESM (named exports for CJS, package.json docs, subpath export patterns, warning removal) #35757

Closed
wants to merge 17 commits into from

Commits on Oct 23, 2020

  1. module: named exports for CJS via static analysis

    PR-URL: nodejs#35249
    Reviewed-By: Mary Marchini <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Zeyu Yang <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    21fca91 View commit details
    Browse the repository at this point in the history
  2. module: refine module type mismatch error cases

    PR-URL: nodejs#35426
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Bradley Farias <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ade34f3 View commit details
    Browse the repository at this point in the history
  3. module: update to [email protected]

    PR-URL: nodejs#35501
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Masashi Hirano <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    57b6119 View commit details
    Browse the repository at this point in the history
  4. doc: rename module pages

    Using a "Modules:" prefix groups all the related pages together when
    using alphabetical order.
    
    Refs: nodejs/modules#539
    
    PR-URL: nodejs#34663
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    4c714c7 View commit details
    Browse the repository at this point in the history
  5. doc: move package config docs to separate page

    This part of the docs aims to contain documentation regarding package
    configuration that covers both ESM and CJS realms.
    
    * Move Enabling section
    * Update Enabling section
    * Remove -u flag
    * Package scopes do not carry through `node_modules` folders
    
    Refs: nodejs/modules#539
    
    Co-authored-by: Geoffrey Booth <[email protected]>>
    Co-authored-by: Guy Bedford <[email protected]>
    
    PR-URL: nodejs#34748
    Reviewed-By: Derek Lewis <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    b517ae8 View commit details
    Browse the repository at this point in the history
  6. doc: document support for package.json fields

    Fixes: nodejs#33143
    
    PR-URL: nodejs#34970
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    cc303a9 View commit details
    Browse the repository at this point in the history
  7. module: exports pattern support

    PR-URL: nodejs#34718
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7b76e75 View commit details
    Browse the repository at this point in the history
  8. doc: edit subpath export patterns introduction

    * Use parallel construction in the two sentences
    * Backticks around _package.json_ to match rest of file
    * Add comma for readability
    * Own the recommendation ("we recommend")
    
    PR-URL: nodejs#35254
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Trott authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    55d15e6 View commit details
    Browse the repository at this point in the history
  9. doc: refine require/import conditions constraints

    PR-URL: nodejs#35311
    Reviewed-By: Jan Krems <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3b49965 View commit details
    Browse the repository at this point in the history
  10. doc: packages docs feedback

    PR-URL: nodejs#35370
    Reviewed-By: Derek Lewis <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ee644b4 View commit details
    Browse the repository at this point in the history
  11. doc: copyedit packages.md

    Some minor adjustments, mostly moving things to present tense and
    avoiding the ambiguity of _may_.
    
    Refs: nodejs#35370 (comment)
    
    PR-URL: nodejs#35427
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    728ddbf View commit details
    Browse the repository at this point in the history
  12. doc: fix conditional exports flag removal version

    PR-URL: nodejs#35428
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e1958d5 View commit details
    Browse the repository at this point in the history
  13. doc: add history entry for exports patterns

    PR-URL: nodejs#35410
    Refs: nodejs#34718
    Reviewed-By: Rich Trott <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    6c27021 View commit details
    Browse the repository at this point in the history
  14. doc,esm: add history support info

    Documents which versions of Node.js support which ESM-feature.
    
    PR-URL: nodejs#35395
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e8a7201 View commit details
    Browse the repository at this point in the history
  15. module: remove experimental modules warning

    PR-URL: nodejs#31974
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    guybedford authored and aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    63fffcf View commit details
    Browse the repository at this point in the history
  16. doc,esm: document experimental warning removal

    PR-URL: nodejs#35750
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    aduh95 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    18c9216 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. esm: use "node:" namespace for builtins

    PR-URL: nodejs#35387
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Bradley Farias <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    guybedford authored and aduh95 committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3e18962 View commit details
    Browse the repository at this point in the history