-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add history entry for exports patterns #35410
Conversation
Review requested:
|
Commit Queue failed- Loading data for nodejs/node/pull/35410 ✔ Done loading data for nodejs/node/pull/35410 ----------------------------------- PR info ------------------------------------ Title doc: add history entry for exports patterns (#35410) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exports-patterns-history-entry -> nodejs:master Labels doc Commits 3 - doc: add history entry for exports patterns - Node.js 14.13.0 - Update doc/api/packages.md Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Tue, 29 Sep 2020 09:11:26 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Commit Queue failed- Loading data for nodejs/node/pull/35410 ✔ Done loading data for nodejs/node/pull/35410 ----------------------------------- PR info ------------------------------------ Title doc: add history entry for exports patterns (#35410) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exports-patterns-history-entry -> nodejs:master Labels commit-queue, doc Commits 3 - doc: add history entry for exports patterns - Node.js 14.13.0 - Update doc/api/packages.md Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Tue, 29 Sep 2020 09:11:26 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 35410 From https://github.com/nodejs/node * branch refs/pull/35410/merge -> FETCH_HEAD ✔ Fetched commits as 96c37b33126c..0f54c59f4441 -------------------------------------------------------------------------------- Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 0f54aa01f3] doc: add history entry for exports patterns Author: Antoine du Hamel Date: Tue Sep 29 11:08:55 2020 +0200 1 file changed, 4 insertions(+) Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 742fba0b89] Node.js 14.13.0 Author: Antoine du Hamel Date: Tue Sep 29 16:17:53 2020 -0400 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 6049e590fc] Update doc/api/packages.md Author: Antoine du Hamel Date: Thu Oct 1 08:28:56 2020 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) |
PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <[email protected]>
0f54c59
to
78f2b11
Compare
Landed in 78f2b11. |
PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #35757 PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #35757 PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <[email protected]>
Refs: #34718
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes