Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add history entry for exports patterns #35410

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 29, 2020

Refs: #34718

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 29, 2020
doc/api/packages.md Outdated Show resolved Hide resolved
doc/api/packages.md Outdated Show resolved Hide resolved
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35410
✔  Done loading data for nodejs/node/pull/35410
----------------------------------- PR info ------------------------------------
Title      doc: add history entry for exports patterns (#35410)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exports-patterns-history-entry -> nodejs:master
Labels     doc
Commits    3
 - doc: add history entry for exports patterns
 - Node.js 14.13.0
 - Update doc/api/packages.md
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Doc-only changes
   ℹ  This PR was created on Tue, 29 Sep 2020 09:11:26 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 8, 2020
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 8, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35410
✔  Done loading data for nodejs/node/pull/35410
----------------------------------- PR info ------------------------------------
Title      doc: add history entry for exports patterns (#35410)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exports-patterns-history-entry -> nodejs:master
Labels     commit-queue, doc
Commits    3
 - doc: add history entry for exports patterns
 - Node.js 14.13.0
 - Update doc/api/packages.md
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Tue, 29 Sep 2020 09:11:26 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 35410
From https://github.com/nodejs/node
 * branch                  refs/pull/35410/merge -> FETCH_HEAD
✔  Fetched commits as 96c37b33126c..0f54c59f4441
--------------------------------------------------------------------------------
Auto-merging doc/api/packages.md
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command.
[master 0f54aa01f3] doc: add history entry for exports patterns
 Author: Antoine du Hamel 
 Date: Tue Sep 29 11:08:55 2020 +0200
 1 file changed, 4 insertions(+)
Auto-merging doc/api/packages.md
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command.
[master 742fba0b89] Node.js 14.13.0
 Author: Antoine du Hamel 
 Date: Tue Sep 29 16:17:53 2020 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging doc/api/packages.md
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command.
[master 6049e590fc] Update doc/api/packages.md
 Author: Antoine du Hamel 
 Date: Thu Oct 1 08:28:56 2020 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add history entry for exports patterns

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott [email protected]

[detached HEAD 926ab97244] doc: add history entry for exports patterns
Author: Antoine du Hamel [email protected]
Date: Tue Sep 29 11:08:55 2020 +0200
1 file changed, 4 insertions(+)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Node.js 14.13.0

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott [email protected]

[detached HEAD 9a6b0191cd] Node.js 14.13.0
Author: Antoine du Hamel [email protected]
Date: Tue Sep 29 16:17:53 2020 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/packages.md

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott [email protected]

[detached HEAD 6e3ebd5063] Update doc/api/packages.md
Author: Antoine du Hamel [email protected]
Date: Thu Oct 1 08:28:56 2020 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.
✔ 926ab97244cdc2c5afeec57cf913e2e90124ab47
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 9a6b0191cd5c03522a04e2b6ed304e52503453bf
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 6e3ebd5063a9a954b43079819a3980faa089f279
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.

@aduh95 aduh95 force-pushed the exports-patterns-history-entry branch from 0f54c59 to 78f2b11 Compare October 8, 2020 23:02
@aduh95 aduh95 merged commit 78f2b11 into nodejs:master Oct 8, 2020
@aduh95 aduh95 deleted the exports-patterns-history-entry branch October 8, 2020 23:02
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 8, 2020

Landed in 78f2b11.

BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
aduh95 added a commit to aduh95/node that referenced this pull request Oct 23, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
Backport-PR-URL: #35757
PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Backport-PR-URL: #35757
PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants