Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test for symlinks #3418

Closed
wants to merge 3 commits into from
Closed

test: fix flaky test for symlinks #3418

wants to merge 3 commits into from

Commits on Oct 18, 2015

  1. test: fix flaky test for symlinks 

    If the symlink portion of the test was being skipped due to a
combination of OS support and user privileges, then an assertion would
always fail. This fixes that problem, improves assertion error reporting
and renames the test to make it clear that it is a test for links and
not just symlinks.

Fixes: nodejs#3311
    @Trott
    Trott committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    193c6b2 View commit details
    Browse the repository at this point in the history

  2. fixup

    @Trott
    Trott committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    2475e1b View commit details
    Browse the repository at this point in the history

  3. fixup

    @Trott
    Trott committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    5e12a31 View commit details
    Browse the repository at this point in the history