Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-fs-symlink #3311

Closed
joaocgreis opened this issue Oct 10, 2015 · 3 comments
Closed

Investigate flaky test test-fs-symlink #3311

joaocgreis opened this issue Oct 10, 2015 · 3 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@joaocgreis
Copy link
Member

Examples of failures:

Failed every time I tried it in Windows 10.
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Oct 10, 2015
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform. and removed build Issues and PRs related to build files or the CI. labels Oct 10, 2015
@brendanashworth
Copy link
Contributor

So this isn't flaky but it just doesn't work on windows 10, right?

@joaocgreis
Copy link
Member Author

That's likely to be it, yes. I didn't get a chance to look at it yet, just opened the issue since we have Windows 10 on CI now and it's failing there.

@Trott Trott mentioned this issue Oct 17, 2015
Closed
@Trott
Copy link
Member

Trott commented Oct 17, 2015

I believe #3418 will fix this.

Trott added a commit to Trott/io.js that referenced this issue Oct 18, 2015
@Trott
test: fix flaky test for symlinks
193c6b2 
If the symlink portion of the test was being skipped due to a
combination of OS support and user privileges, then an assertion would
always fail. This fixes that problem, improves assertion error reporting
and renames the test to make it clear that it is a test for links and
not just symlinks.

Fixes: nodejs#3311
@Trott Trott closed this as completed in 1c57845 Oct 20, 2015
Trott added a commit that referenced this issue Oct 21, 2015
@Trott @rvagg
test: fix flaky test for symlinks
f78c8e7 
If the symlink portion of the test was being skipped due to a
combination of OS support and user privileges, then an assertion would
always fail. This fixes that problem, improves assertion error reporting
and splits the test to make it clear that it is a test for links and
symlinks.

Fixes: #3311
PR-URL: #3418
Reviewed-By: Johan Bergström <[email protected]>
Trott added a commit that referenced this issue Oct 26, 2015
@Trott @jasnell
test: fix flaky test for symlinks
d62d158 
If the symlink portion of the test was being skipped due to a
combination of OS support and user privileges, then an assertion would
always fail. This fixes that problem, improves assertion error reporting
and splits the test to make it clear that it is a test for links and
symlinks.

Fixes: #3311
PR-URL: #3418
Reviewed-By: Johan Bergström <[email protected]>
Trott added a commit that referenced this issue Oct 29, 2015
@Trott @jasnell
test: fix flaky test for symlinks
155c778 
If the symlink portion of the test was being skipped due to a
combination of OS support and user privileges, then an assertion would
always fail. This fixes that problem, improves assertion error reporting
and splits the test to make it clear that it is a test for links and
symlinks.

Fixes: #3311
PR-URL: #3418
Reviewed-By: Johan Bergström <[email protected]>
This was referenced Feb 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Sep 26, 2022
Open
@137717unity 137717unity mentioned this issue Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 6, 2022
Open
@137717unity 137717unity mentioned this issue Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this issue Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 9, 2022
Open
@kissofire kissofire mentioned this issue Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test for symlinks Trott/io.js
4 participants
@mscdex @joaocgreis @Trott @brendanashworth