Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove legacy mode deprecation in assert #28909

Merged
merged 0 commits into from
Aug 2, 2019
Merged

doc: remove legacy mode deprecation in assert #28909

merged 0 commits into from
Aug 2, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 31, 2019

The deprecation was revoked in
#28892.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 31, 2019
@Trott Trott requested a review from cjihrig July 31, 2019 17:32
@Trott
Copy link
Member Author

Trott commented Jul 31, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3815/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2019
@Trott Trott closed this Aug 2, 2019
@Trott Trott force-pushed the remove-from-docs branch from d024b23 to 36864a6 Compare August 2, 2019 19:00
@Trott
Copy link
Member Author

Trott commented Aug 2, 2019

Landed in 36864a6

@Trott Trott deleted the remove-from-docs branch August 2, 2019 19:00
@Trott Trott merged commit 36864a6 into nodejs:master Aug 2, 2019
targos pushed a commit that referenced this pull request Aug 2, 2019
@Trott @targos
doc: remove legacy mode deprecation in assert
f4abf17 
The deprecation was revoked in
#28892.

PR-URL: #28909
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @silverwind @jasnell @lpinca @cjihrig @trivikr @nodejs-github-bot