Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.8.0 release proposal #29017

Merged
merged 88 commits into from
Aug 6, 2019
Merged

v12.8.0 release proposal #29017

merged 88 commits into from
Aug 6, 2019

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Aug 6, 2019

Notable changes

  • crypto:
    • The outputLength option is added to crypto.createHash (Tobias Nießen) #28805
    • The maxmem range is increased from 32 to 53 bits (Tobias Nießen) #28799
  • doc:
    • Legacy assert mode deprecation (DEP0089) is revoked (Colin Ihrig) #28892
  • n-api:
    • Added APIs for per-instance state management (Gabriel Schulhof) #28682
  • report:
    • Network interfaces get included in the report (Colin Ihrig) #28911
  • src:
    • v8.GetHeapCodeAndMetadataStatistics() is now exported (Yuriy Vasiyarov) #27978

Commits

  • [d3426ee9f1] - assert: avoid potentially misleading reference to object identity (Anna Henningsen) #28824
  • [bbcf9f0625] - benchmark: swap var for let in buffer benchmarks (Alex Ramirez) #28867
  • [f2c1f3613b] - benchmark: swap var for let in util benchmarks (Alex Ramirez) #28867
  • [048db38ada] - benchmark: swap var for let in url benchmarks (Alex Ramirez) #28867
  • [391fe46378] - benchmark, http: refactor for code consistency (Alex Ramirez) #28791
  • [dcef7b8cc1] - build: include stubs in shared library (Jeroen Ooms) #28897
  • [470db47cb4] - build: remove support for s390 (but not s390x) (Ben Noordhuis) #28883
  • [25aa2228e4] - build: generate openssl config for BSD-x86 (Ben Noordhuis) #28806
  • [fb57bc4be4] - build: do not mix spaces and tabs in Makefile (Luigi Pinca) #28881
  • [9e7c66280e] - build: ignore backup files (Adam Majer) #28865
  • [24b9d29650] - build: uname -m is amd64 on freebsd, not x86_64 (Ben Noordhuis) #28804
  • [82f263d022] - build,tools: support building with Visual Studio 2019 (Michaël Zasso) #28781
  • [a7ef102a66] - crypto: add null check to outputLength logic (Colin Ihrig) #28864
  • [3a62202a54] - crypto: fix handling of malicious getters (scrypt) (Tobias Nießen) #28838
  • [b7c6ad595b] - (SEMVER-MINOR) crypto: add outputLength option to crypto.createHash (Tobias Nießen) #28805
  • [86f4c68d6a] - crypto: update root certificates (Sam Roberts) #28808
  • [e0e776331a] - (SEMVER-MINOR) crypto: increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799
  • [11470d5c26] - deps: upgrade npm to 6.10.2 (isaacs) #28853
  • [9b02f3623b] - deps: dlloads node static linked executable (Luca Lindhorst) #28045
  • [24b8f2000c] - deps: remove backup files (Adam Majer) #28865
  • [ae56a232e1] - deps: backport b107214 from upstream V8 (Anna Henningsen) #28850
  • [19dad196e0] - deps: float 15d7e79 from openssl (Tobias Nießen) #28796
  • [9dfa636083] - dgram: changed 'var' to 'let' and 'const' (Manuel Ochoa Loaiza) #28357
  • [02a50c3b42] - doc: remove use of you (Michael Dawson) #28919
  • [bdd442fe35] - doc: describe NODE_OPTIONS interop w/cmd line opts (Alex Aubuchon) #28928
  • [57f5d50a3b] - doc: fix sorting nit in sections of http.md (Vse Mozhet Byt) #28943
  • [f4abf17d36] - doc: remove legacy mode deprecation in assert (Rich Trott) #28909
  • [0ac6d28f80] - doc: writableFinished is true before 'finish' (Robert Nagy) #28811
  • [7c80963d98] - doc: include "exports" resolver specification (guybedford) #28899
  • [5f07f49933] - doc: revoke DEP0089 (Colin Ihrig) #28892
  • [3e6342958b] - doc: add example about emitter.emit in events documentation (Felipe Duitama) #28374
  • [a28db5f470] - doc: add example of event close for child_process (Laura Ciro) #28376
  • [085eb4828b] - doc: fixup esm resolver spec formatting (Guy Bedford) #28885
  • [5533d48290] - doc: correct import statement (himself65) #28876
  • [ffc7a00c10] - doc: add documentation for stream.destroyed (Robert Nagy) #28815
  • [454e879a4a] - doc: fix incorrect name in report docs (Colin Ihrig) #28830
  • [881e345e0c] - doc: describe why new Buffer() is problematic (Sam Roberts) #28825
  • [95b87ce24a] - doc: claim NODE_MODULE_VERSION=76 for Electron 8 (Samuel Attard) #28809
  • [0667d0c6c2] - doc: add documentation for response.flushHeaders() (Luigi Pinca) #28807
  • [c0a044849d] - doc: fix type in NSS update instructions (Sam Roberts) #28808
  • [d0b1fb3311] - doc: api/stream.md typo from writeable to writable (Cotton Hou) #28822
  • [727ffe4720] - domain: use strong reference to domain while active (Anna Henningsen) #28313
  • [c9c7256f50] - http: reset parser.incoming when server response is finished (Anna Henningsen) #28646
  • [7d9eb17d30] - http2: destroy when settingsFn throws an error (himself65) #28908
  • [fa82cbc6cb] - http2: destructure constants from require call (Daniel Nalborczyk) #28176
  • [d0d31498d1] - http2: add constant to already destructured constants (Daniel Nalborczyk) #28176
  • [d72b6820bd] - inspector: report all workers (Eugene Ostroukhov) #28872
  • [464136fbc2] - lib: replace var with let in loaders.js (mbj36) #28081
  • [386d5d70fb] - lib: support min/max values in validateInteger() (Colin Ihrig) #28810
  • [2236affbf8] - module: exports error as MODULE_NOT_FOUND (Guy Bedford) #28905
  • [d9084d29fe] - module: unify package exports test for CJS and ESM (Jan Krems) #28831
  • [2262526562] - module: implement "exports" proposal for CommonJS (Jan Krems) #28759
  • [c93df0cfc3] - n-api: refactoring napi_create_function testing (Octavian Soldea) #28894
  • [e6b3bfe111] - n-api: refactor a previous commit (Octavian Soldea) #28848
  • [860c0d89b6] - (SEMVER-MINOR) n-api: add APIs for per-instance state management (Gabriel Schulhof) #28682
  • [3c52dbe15b] - net: shallow copy option when create Server (himself65) #28924
  • [1f82929ed0] - path: improve normalization performance (Brian White) #28948
  • [5d5c89a8f7] - policy: add dependencies map for resources (Bradley Farias) #28767
  • [4b91e4dafd] - (SEMVER-MINOR) report: include network interfaces in report (Colin Ihrig) #28911
  • [e0951c80f6] - report: loop over uv_cpu_info() results (Colin Ihrig) #28829
  • [4a747f6037] - Revert "src: remove trace_sync_io_ from env" (Сковорода Никита Андреевич) #28926
  • [d601a0a9c0] - src: allow generic C++ callables in SetImmediate() (Anna Henningsen) #28704
  • [3d51d3039c] - src: large pages fix FreeBSD fix region size (David Carlier) #28735
  • [cce208794e] - (SEMVER-MINOR) src: export v8.GetHeapCodeAndMetadataStatistics() (Yuriy Vasiyarov) #27978
  • [32cf344f8e] - src: readlink("/proc/self/exe") -> uv_exename() (Ben Noordhuis) #28333
  • [1b0d67b1e7] - src: fix OpenBSD build (David Carlier) #28384
  • [406c50c1d4] - src: read break_node_first_line from the inspect options (Samuel Attard) #28034
  • [8db43b1ff5] - src: move relative uptime init (Micha Hanselmann) #28849
  • [e334c1f13b] - src: fix type name in comment (Ben Noordhuis) #28320
  • [cf071a01f2] - stream: resolve perf regression introduced by V8 7.3 (Matteo Collina) #28842
  • [0f8f552105] - test: refactor test-fs-stat.js (Rich Trott) #28929
  • [c38952610e] - test: add tests for spaces in folder names (PaulBags) #28819
  • [efe9b97d40] - test: refactor test-beforeexit-event-exit using mustNotCall (himself65) #28901
  • [c42eb5dd55] - test: refactoring test_error testing (himself65) #28902
  • [b6e174b4f5] - test: use assert.throws() in test-require-json.js (Alejandro Nanez) #28358
  • [19070e442d] - test: fix nits in test/fixtures/tls-connect.js (Luigi Pinca) #28880
  • [31aa33bdcb] - test: fix race in test-http2-origin (Alba Mendez) #28903
  • [9b47f77571] - test: udpate test comment description (Andres Bedoya) #28351
  • [a0f89a2845] - test: refactor test using assert instead of try/catch (Juan Bedoya) #28346
  • [2142b6d3d1] - test: improve test-async-hooks-http-parser-destroy (Gerhard Stoebich) #28253
  • [f6051f9506] - test: specialize OOM check for AIX (Sam Roberts) #28857
  • [84efadf263] - test, util: refactor isObject in test-util (Alex Ramirez) #28878
  • [0b6a84a861] - test,report: relax CPU match requirements (Anna Henningsen) #28884
  • [a38fecdb20] - tools: update certdata.txt (Sam Roberts) #28808
  • [b282c8512b] - vm: increase code coverage of source_text_module.js (kball) #28350
  • [43acce1925] - worker: handle calling terminate when kHandler is null (elyalvarado) #28370

tniessen and others added 30 commits August 2, 2019 22:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The upstream commit fixes an incorrect initialization of memory in
rand_lib.c. This fixes all errors that are reported by valgrind during
startup.

Origin: openssl/openssl@15d7e7997e219fc

PR-URL: #28796
Fixes: #28739
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
The comment refers to an exception type that JS land throws on the C++
code's behalf but apparently I changed the JS name before landing the
pull request and forgot to update the comment.

Refs: #20816

PR-URL: #28320
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This commit updates validateInteger() in two ways:

- Number.isInteger() is used instead of Number.isSafeInteger().
  This ensures that all integer values are supported.
- Minimum and maximum values are supported. They default to
  the min and max safe integer values, but can be customized.

PR-URL: #28810
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Refs: jkrems/proposal-pkg-exports#36
Refs: #28568

PR-URL: #28759
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
PR-URL: #28822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Fixes: #28755

PR-URL: #28799
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This is the certdata.txt[0] from NSS 3.45, released on 2019-07-05.

This is the version of NSS that will ship in Firefox 69 on
2019-09-03.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_45_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #28808
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added: (none)

Certificates removed:
- Certinomis - Root CA

PR-URL: #28808
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The perl script must be fully named, correct so that the command can be
copy-pasted-run from the docs.

PR-URL: #28808
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: #13150

PR-URL: #28804
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Leverage `using` semantics for repeated usage of
v8 artifacts.

PR-URL: #28801
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #28807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28809
Refs: https://github.com/electron/electron/projects/20#card-24099810
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Original commit message:

    [code-serializer] Handlify in CodeSerializer::Deserialize

    This section potentially contains allocations and thus gc, all object
    references should be handlified.

    Bug: v8:9333
    Change-Id: I5814e66e8b9b75a8bd952afecae7a3a27b42a642
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647695
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62012}

(This required resolution of a few merge conflicts, so it’s essentially
a manual backport.)

Refs: v8/v8@b107214
Refs: #28847

PR-URL: #28850
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
When an uncaught exception is thrown inside a domain, the domain is
removed from the stack as of 43a5170.
This means that it might not be kept alive as an object anymore,
and may be garbage collected before the `after()` hook can run,
which tries to exit it as well.

Resolve that by making references to the domain strong while it is
active.

Fixes: #28275

PR-URL: #28313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Existing docs weren't clear on the actual problem. In addition, the text
described 8.0.0 as being a future Node.js release, so adjust language
to reflect that 8.0.0 is in the past (while not losing important
information about what the pre-8.x behaviour was).

PR-URL: #28825
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
allow native addons to store their data on and retrieve their data from
`napi_env`. `napi_set_instance_data()` accepts a finalizer which is
called when the `node::Environment()` is destroyed.

This entails rendering the `napi_env` local to each add-on.

Fixes: nodejs/abi-stable-node#378
PR-URL: #28682
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In diagnostic reports, the CPUs are listed in a "cpus" field.
This commit fixes the docs, which refer to the field as "osCpus"

PR-URL: #28830
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The code currently loops over the results, but only the
first result is accessed.

PR-URL: #28829
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Often, the word “identical” when referring to JS objects will
be read as referring to having the same object identity (which is
called “reference equality” here), but what the error message is
trying to say here is that the objects are different but yield the
same `util.inspect()` output.

Since `util.inspect()` output represents the structure rather than
the identity of objects, (hopefully) clarify the error message to
reflect that.

PR-URL: #28824
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This change adds an outputLength option to crypto.createHash which
allows users to produce variable-length hash values using XOF hash
functons.

Fixes: #28757
PR-URL: #28805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
It is possible to bypass parameter validation in crypto.scrypt and
crypto.scryptSync by crafting option objects with malicious getters as
demonstrated in the regression test. After bypassing validation, any
value can be passed to the C++ layer, causing an assertion to crash
the process.

Fixes: #28836

PR-URL: #28838
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Adds a "dependencies" field to resources in policy manifest files.
In order to ease development and testing while using manifests,
wildcard values for both "dependencies" and "integrity" have been
added using the boolean value "true" in the policy manifest.

PR-URL: #28767
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28815
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This is a refactoring of #27628
following #28505.

This change factors out functions `add_last_status()` and
`add_returned_status()` so they may be reused in the tests for passing
information about the last error status and/or a returned `napi_status`
to JavaScript.

PR-URL: #28848
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This commit contains two fixes:
1. use instanceof instead of Object.getPrototypeOf, as checking an
   object prototype with Object.getPrototypeOf is slower
   than an instanceof check.
2. avoid parseInt(undefined, 10) to get NaN as it regressed.

PR-URL: #28842
Fixes: #28586
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Add a `vs2019` option to `vcbuild.bat` to use VS 2019 instead of VS 2017

PR-URL: #28781
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Assumption that if memory can be malloc()ed it can be used is not true
on AIX. Later access of the allocated pages can trigger SIGKILL if there
are insufficient VM pages.

Use psdanger() to better estimate available memory.

Fixes: nodejs/build#1849

More info:
- https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/generalprogramming/sys_mem_alloc.html
- https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/p_bostechref/psdanger.html

Related to:
- nodejs/build#1820 (comment)
- #28469
- #28516

PR-URL: #28857
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28849
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This resolves a memory leak for keep-alive connections with a naïve
approach.

Fixes: #9668

PR-URL: #28646
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
himself65 and others added 4 commits August 6, 2019 14:39
PR-URL: #28924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
We generally avoid the use of 'you'.

PR-URL: #28919
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28948
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #28853
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. v12.x labels Aug 6, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

addaleax commented Aug 6, 2019

I’d put this under assert:, rather than doc:

v8.GetHeapCodeAndMetadataStatistics()` is now exported (Yuriy Vasiyarov) #27978

The commit message and what actually landed mismatch in that the actual method name is v8.getHeapCodeStatistics().

Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    #28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #29017
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 6, 2019

CI and CITGM seem fine.

@BridgeAR BridgeAR merged commit 77d8f0c into v12.x Aug 6, 2019
BridgeAR added a commit that referenced this pull request Aug 6, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 6, 2019
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    nodejs#28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) nodejs#28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    nodejs#28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    nodejs#28682
* report:
  * Network interfaces get included in the report (cjihrig)
    nodejs#28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) nodejs#27978

PR-URL: nodejs#29017
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Aug 6, 2019
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Aug 6, 2019
@BridgeAR BridgeAR deleted the v12.8.0-proposal branch December 3, 2019 22:51
@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.