Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup esm resolver spec formatting #28885

Closed
wants to merge 1 commit into from
Closed

doc: fixup esm resolver spec formatting #28885

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

This fixes up the formatting of the esm resolver spec in the docs, which is currently showing some markdown issues - https://nodejs.org/dist/latest-v12.x/docs/api/esm.html#esm_resolution_algorithm.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 28, 2019
@targos
Copy link
Member

targos commented Jul 29, 2019

👍 to fast-track

@guybedford guybedford added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 29, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24753/

@guybedford
Copy link
Contributor Author

Landed in 816db9e.

@guybedford guybedford closed this Jul 30, 2019
@guybedford guybedford deleted the guybedford-patch-1 branch July 30, 2019 00:26
guybedford added a commit that referenced this pull request Jul 30, 2019
@guybedford
doc: fixup esm resolver spec formatting
816db9e 
PR-URL: #28885
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 2, 2019
@guybedford @targos
doc: fixup esm resolver spec formatting
085eb48 
PR-URL: #28885
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guybedford @targos @nodejs-github-bot @jasnell @lpinca @cjihrig