Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 6.10.2 #28853

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.10.2 #28853

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jul 25, 2019

v6.10.2 (2019-07-23):

tl;dr - Fixes several issues with the cache when npm is run as sudo on Unix systems.

TESTING

BUGFIXES

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jul 25, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Copy link
Member

Trott commented Aug 1, 2019

6.10.2 was released 9 days ago, and our policy is that it can land in master after 14 days, so this can land on or around August 5.

@Trott
Copy link
Member

Trott commented Aug 1, 2019

Rebased to eliminate conflict (deleted backup file deps/npm/node_modules/copy-concurrently/README.md~, but that's it) and force pushed.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@irega
Copy link

irega commented Aug 6, 2019

waiting impatiently for the merge! 🎉 🎉 🎉

@targos
Copy link
Member

targos commented Aug 6, 2019

Landed in d7d321b

@targos targos closed this Aug 6, 2019
targos pushed a commit that referenced this pull request Aug 6, 2019
PR-URL: #28853
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
BridgeAR pushed a commit that referenced this pull request Aug 6, 2019
PR-URL: #28853
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 19, 2019
PR-URL: #28853
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants