-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve test-async-hooks-http-parser-destroy #28253
test: improve test-async-hooks-http-parser-destroy #28253
Conversation
I don't think all these test fails are caused by my changes... |
Seems the test I modified fails now in Other fails look unrelated to me. |
Ignore unrelated fails. To test the worker thing locally: |
According to docs the use of |
I was able to reproduce a similar fail locally and was able to fix it by closing server later. I haven't fully understood why this matters but it seems |
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: nodejs#28112
e8b11c4
to
5ebef48
Compare
Rebased as indicated at #28610 (comment) - maybe this helps CI. If not I'm out of ideas and will abandon this one. |
If I understand CI correct again an unrelated fail from |
Landed in 8007134. |
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: nodejs#28112 PR-URL: nodejs#28253 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Improve asserts to distinguish between reequest and response parsers. Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete. Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts. Refs: #28112 PR-URL: #28253 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Improve asserts to distinguish between reequest and response parsers.
Change the assert sequence to first assert on the number of ids to easier identify if some operation is missing/incomplete.
Destroy HTTP agent once expected number of events have been seen to avoid waiting on socket timeouts.
Refs: #28112
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes