Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update llhttp to 1.1.4 #28154

Closed
wants to merge 1 commit into from
Closed

deps: update llhttp to 1.1.4 #28154

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Jun 10, 2019

See: nodejs/llhttp#26

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @nodejs/http

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@indutny indutny mentioned this pull request Jun 10, 2019
Closed
@addaleax addaleax added the http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. label Jun 10, 2019
@indutny
Copy link
Member Author

indutny commented Jun 12, 2019

Landed in c1f0cbe. Thank you!

This should be backported to v12, I think?

@indutny indutny closed this Jun 12, 2019
indutny added a commit that referenced this pull request Jun 12, 2019
@indutny
deps: update llhttp to 1.1.4
c1f0cbe 
See: nodejs/llhttp#26

PR-URL: #28154
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@indutny indutny deleted the feature/update-llhttp-1.1.4 branch June 12, 2019 21:57
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@indutny @BridgeAR
deps: update llhttp to 1.1.4
084ffd8 
See: nodejs/llhttp#26

PR-URL: #28154
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@indutny @nodejs-github-bot @jasnell @Trott @addaleax @cjihrig @trivikr