http: fix llhttp_finish semantics and add tests
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although implemented in a compatible way `llhttp_finish()` was never properly tested until now. Unsurprisingly, there was an incorrect behavior hidden in there. Fix: #25
|
cc @nodejs/http |
|
The relevant |
bnoordhuis
approved these changes
Jun 10, 2019
indutny
added a commit
that referenced
this pull request
Jun 10, 2019
Although implemented in a compatible way `llhttp_finish()` was never properly tested until now. Unsurprisingly, there was an incorrect behavior hidden in there. Fix: #25 PR-URL: #26 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in e904107, released in 1.1.4 Thanks for review! |
indutny
added a commit
to indutny/io.js
that referenced
this pull request
Jun 10, 2019
4 tasks
indutny
added a commit
to nodejs/node
that referenced
this pull request
Jun 12, 2019
See: nodejs/llhttp#26 PR-URL: #28154 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 17, 2019
See: nodejs/llhttp#26 PR-URL: #28154 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although implemented in a compatible way
llhttp_finish()was neverproperly tested until now. Unsurprisingly, there was an incorrect
behavior hidden in there.
Fix: #25