Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: read break_node_first_line from the inspect options #28034

Closed
wants to merge 1 commit into from
Closed

src: read break_node_first_line from the inspect options #28034

wants to merge 1 commit into from

Conversation

MarshallOfSound
Copy link
Member

There are cases where the debug_options() on the env are different to the options that were passed into inspector::Agent. This is particularly true in Electrons case where we pass the agent a real parsed NodeOptions but give the env an empty one.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 2, 2019
@MarshallOfSound MarshallOfSound mentioned this pull request Jun 2, 2019
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23579/

@BridgeAR BridgeAR requested review from addaleax and bnoordhuis June 4, 2019 11:41
bnoordhuis
bnoordhuis reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM but it needs a rebase. This section changed quite a bit but I think it's written like this now:

if (inspector_agent_->options().break_node_first_line) {

@MarshallOfSound
Copy link
Member Author

Sorry for the delay on this @bnoordhuis , rebased and updated 👍

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 5, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24276/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24283/

@Trott
Copy link
Member

Trott commented Jul 5, 2019

Is it reasonable to write a test for this?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24444/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24452/

@MarshallOfSound
src: read break_node_first_line from the inspect options
633b385 
There are cases where the debug_options() on the env are
different to the options that were passed into inspector::Agent.
@Trott
Copy link
Member

Trott commented Jul 30, 2019

@jasnell @addaleax @BridgeAR Still looks good to you? This got a small change since the last CI and the approvals.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24755/

@Trott
Copy link
Member

Trott commented Jul 30, 2019

@jasnell @addaleax @BridgeAR Still looks good to you? This got a small change since the last CI and the approvals.

Oh, wait, it was just a rebase, I think. Never mind.

@Trott
Copy link
Member

Trott commented Jul 30, 2019 •
edited
Loading

Landed in 4208158.

@Trott Trott closed this Jul 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
@MarshallOfSound @Trott
src: read break_node_first_line from the inspect options
4208158 
There are cases where the debug_options() on the env are
different to the options that were passed into inspector::Agent.

PR-URL: nodejs#28034
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MarshallOfSound MarshallOfSound deleted the use-agent-options branch July 30, 2019 04:09
targos pushed a commit that referenced this pull request Aug 2, 2019
@MarshallOfSound @targos
src: read break_node_first_line from the inspect options
406c50c 
There are cases where the debug_options() on the env are
different to the options that were passed into inspector::Agent.

PR-URL: #28034
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MarshallOfSound @nodejs-github-bot @Trott @bnoordhuis @jasnell @addaleax @BridgeAR