Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.4.288.18 #27066

Merged
merged 2 commits into from
Apr 5, 2019
Merged

deps: patch V8 to 7.4.288.18 #27066

merged 2 commits into from
Apr 5, 2019

Conversation

targos
Copy link
Member

@targos targos commented Apr 3, 2019

Refs: v8/v8@7.4.288.13...7.4.288.17

@nodejs/v8-update

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 3, 2019
@targos targos added dont-land-on-v10.x and removed v8 engine Issues and PRs related to the V8 dependency. labels Apr 3, 2019
@targos
Copy link
Member Author

targos commented Apr 3, 2019

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos changed the title deps: patch V8 to 7.4.288.17 deps: patch V8 to 7.4.288.18 Apr 5, 2019
@targos
Copy link
Member Author

targos commented Apr 5, 2019

Updated to 7.4.288.18. I need at least one more approval.

@targos
Copy link
Member Author

targos commented Apr 5, 2019

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

targos added 2 commits April 5, 2019 08:45
@refack
Copy link
Contributor

refack commented Apr 5, 2019

Landed in c86883c...135b79a31d51939d46b68eaea5249e28c7f67757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants