Skip to content

Commit

Permalink
deps: patch V8 to 7.4.288.18
Browse files Browse the repository at this point in the history
Refs: v8/v8@7.4.288.17...7.4.288.18

PR-URL: #27066
Refs: v8/v8@7.4.288.13...7.4.288.17
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
  • Loading branch information
targos authored and refack committed Apr 5, 2019
1 parent c1d61f2 commit 135b79a
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 4 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 7
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 288
#define V8_PATCH_LEVEL 17
#define V8_PATCH_LEVEL 18

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
6 changes: 3 additions & 3 deletions deps/v8/src/compiler/typed-optimization.cc
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ Reduction TypedOptimization::ReduceSpeculativeNumberAdd(Node* node) {
Node* const value =
graph()->NewNode(simplified()->NumberAdd(), toNum_lhs, toNum_rhs);
ReplaceWithValue(node, value);
return Replace(node);
return Replace(value);
}
return NoChange();
}
Expand Down Expand Up @@ -796,7 +796,7 @@ Reduction TypedOptimization::ReduceSpeculativeNumberBinop(Node* node) {
NumberOpFromSpeculativeNumberOp(simplified(), node->op()), toNum_lhs,
toNum_rhs);
ReplaceWithValue(node, value);
return Replace(node);
return Replace(value);
}
return NoChange();
}
Expand All @@ -811,7 +811,7 @@ Reduction TypedOptimization::ReduceSpeculativeNumberComparison(Node* node) {
Node* const value = graph()->NewNode(
NumberOpFromSpeculativeNumberOp(simplified(), node->op()), lhs, rhs);
ReplaceWithValue(node, value);
return Replace(node);
return Replace(value);
}
return NoChange();
}
Expand Down
23 changes: 23 additions & 0 deletions deps/v8/test/mjsunit/compiler/regress-945644.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --allow-natives-syntax

function f(v5,v6) {
const v16 = [1337,1337,-765470.5051836492];
let v19 = 0;
do {
const v20 = v19 + 1;
const v22 = Math.fround(v20);
v19 = v22;
const v23 = [v20, v22];
function v24() { v20; v22; }
const v33 = v16.indexOf(v19);
} while (v19 < 6);
}

f();
Array.prototype.push(8);
%OptimizeFunctionOnNextCall(f);
f();

0 comments on commit 135b79a

Please sign in to comment.