src: move more version computation code into node_metadata.cc #25115

joyeecheung · 2018-12-18T21:47:18Z

src: move the declaration of http parser versions into node_metadata.h

Instead of putting them in node_internals.h.

src: move GetOpenSSLVersion into node_metadata.cc

Instead of implementing it in node_crypto.cc even though the only
place that needs it is the Metadata::Versions constructor.

src: initialize ICU version in per_process::metadata.versions

Instead of

Initialize the ICU versions in JS land after consulting
internalBinding('config').hasIntl
Joining the version keys in C++
Splitting the keys in JS and call into C++ again to get the value for
each of the keys

Do:

Guard the initialization code behind NODE_HAVE_I18N_SUPPORT
Do the initialization in C++ right after ICU data is loaded
Initialize each version directly using ICU functions/constants,
and put them in per_process::metadata.versions. These will be
copied into process.versions naturally later.
This way, the initialization of the versions won't be called
in worker threads again.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor.

Instead of putting them in node_internals.h.

Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again.

nodejs-github-bot · 2018-12-18T21:47:20Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1996/pipeline

src/node_i18n.cc

joyeecheung · 2018-12-18T22:12:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19664/

Trott · 2018-12-19T01:13:33Z

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19667/ ✔️

joyeecheung · 2018-12-20T23:47:56Z

Landed in 3438f4b...263d137, thanks!

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of putting them in node_internals.h. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins · 2018-12-25T06:48:59Z

This doesn't land cleanly on v11.x, should it be backported?

addaleax · 2019-01-14T15:29:28Z

Applies cleanly now.

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor. PR-URL: #25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of putting them in node_internals.h. PR-URL: #25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again. PR-URL: #25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of putting them in node_internals.h. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of putting them in node_internals.h. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Instead of - Initialize the ICU versions in JS land after consulting internalBinding('config').hasIntl - Joining the version keys in C++ - Splitting the keys in JS and call into C++ again to get the value for each of the keys Do: - Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT` - Do the initialization in C++ right after ICU data is loaded - Initialize each version directly using ICU functions/constants, and put them in per_process::metadata.versions. These will be copied into `process.versions` naturally later. This way, the initialization of the versions won't be called in worker threads again. PR-URL: nodejs#25115 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>

joyeecheung added 3 commits December 19, 2018 03:05

src: move GetOpenSSLVersion into node_metadata.cc

15a80fc

Instead of implementing it in node_crypto.cc even though the only place that needs it is the `Metadata::Versions` constructor.

src: move the declaration of http parser versions into node_metadata.h

c6b5f2a

Instead of putting them in node_internals.h.

joyeecheung requested review from srl295 and addaleax December 18, 2018 21:47

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 18, 2018

srl295 approved these changes Dec 18, 2018

View reviewed changes

src/node_i18n.cc Show resolved Hide resolved

richardlau approved these changes Dec 19, 2018

View reviewed changes

JungMinu approved these changes Dec 19, 2018

View reviewed changes

joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2018

jasnell approved these changes Dec 19, 2018

View reviewed changes

joyeecheung closed this Dec 20, 2018

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

addaleax removed the backport-requested-v11.x label Jan 14, 2019

BridgeAR mentioned this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

BethGriggs added the backport-requested-v10.x label Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: move more version computation code into node_metadata.cc #25115

src: move more version computation code into node_metadata.cc #25115

joyeecheung commented Dec 18, 2018

nodejs-github-bot commented Dec 18, 2018

joyeecheung commented Dec 18, 2018

Trott commented Dec 19, 2018 •

edited

Loading

joyeecheung commented Dec 20, 2018

MylesBorins commented Dec 25, 2018

addaleax commented Jan 14, 2019

src: move more version computation code into node_metadata.cc #25115

src: move more version computation code into node_metadata.cc #25115

Conversation

joyeecheung commented Dec 18, 2018

src: move the declaration of http parser versions into node_metadata.h

src: move GetOpenSSLVersion into node_metadata.cc

src: initialize ICU version in per_process::metadata.versions

Checklist

nodejs-github-bot commented Dec 18, 2018

joyeecheung commented Dec 18, 2018

Trott commented Dec 19, 2018 • edited Loading

joyeecheung commented Dec 20, 2018

MylesBorins commented Dec 25, 2018

addaleax commented Jan 14, 2019

Trott commented Dec 19, 2018 •

edited

Loading