Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move more version computation code into node_metadata.cc #25115

Closed
wants to merge 3 commits into from
Closed

src: move more version computation code into node_metadata.cc #25115

wants to merge 3 commits into from

Commits on Dec 18, 2018

  1. src: move GetOpenSSLVersion into node_metadata.cc 

    Instead of implementing it in node_crypto.cc even though the only
place that needs it is the `Metadata::Versions` constructor.
    @joyeecheung
    joyeecheung committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    15a80fc View commit details
    Browse the repository at this point in the history

  2. src: move the declaration of http parser versions into node_metadata.h 

    Instead of putting them in node_internals.h.
    @joyeecheung
    joyeecheung committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    c6b5f2a View commit details
    Browse the repository at this point in the history

  3. src: initialize ICU version in per_process::metadata.versions 

    Instead of

- Initialize the ICU versions in JS land after consulting
  internalBinding('config').hasIntl
- Joining the version keys in C++
- Splitting the keys in JS and call into C++ again to get the value for
  each of the keys

Do:

- Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT`
- Do the initialization in C++ right after ICU data is loaded
- Initialize each version directly using ICU functions/constants,
  and put them in per_process::metadata.versions. These will be
  copied into `process.versions` naturally later.
  This way, the initialization of the versions won't be called
  in worker threads again.
    @joyeecheung
    joyeecheung committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    b864793 View commit details
    Browse the repository at this point in the history