test: enable trace-events tests for workers #23698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers.
Currently crashes when run with workers. Real bug?
richardlau
changed the title
This comment has been minimized.
This comment has been minimized.
richardlau
added
trace_events
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Oct 16, 2018
This comment has been minimized.
This comment has been minimized.
|
/cc @ofrobots |
|
|
cjihrig
approved these changes
Oct 17, 2018
richardlau
added
the
author ready
|
Landed in 23f8b7d. |
danbev
pushed a commit
that referenced
this pull request
Oct 19, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Should this be backported to |
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
|
Backport PR: #23882 |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Nov 2, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Backport-PR-URL: nodejs#23882 PR-URL: nodejs#23698 Refs: nodejs#23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js
MylesBorins
pushed a commit
that referenced
this pull request
Nov 4, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
cwdoption forchild_processinstead ofprocess.chdir()to enable the trace events tests to run on workers.
Refs: #23674 (comment)
I've split one of the tests (test-trace-events-api.js) into its own commitbecause it crashes when run under workers. Is this indicative of a real
bug?
Edit:
test-trace-events-api.jsupdated to be skipped for workers dueto #22767
cc @nodejs/trace-events @nodejs/workers
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes