[v10.x backport] test: enable trace-events tests for workers #23882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
force-pushed
the
backport-23698-to-v10.x
branch
from
25c2d1b
to
59bb5ab
Compare
3 tasks
|
Only failing CI is |
addaleax
force-pushed
the
v10.x-staging
branch
from
8b431ad
to
3f63297
Compare
MylesBorins
force-pushed
the
v10.x-staging
branch
from
3f63297
to
8e7a12f
Compare
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Backport-PR-URL: nodejs#23882 PR-URL: nodejs#23698 Refs: nodejs#23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js
richardlau
force-pushed
the
backport-23698-to-v10.x
branch
from
59bb5ab
to
9e39441
Compare
|
Rebased, new CI: https://ci.nodejs.org/job/node-test-pull-request/18293/ |
|
CI is passing. Just need reviews. |
targos
approved these changes
Nov 2, 2018
|
@nodejs/lts |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 4, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
landed in 8552bb4 |
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Use the `cwd` option for `child_process` instead of `process.chdir()` to enable the trace events tests to run on workers. Conflicts: test/parallel/test-trace-events-binding.js test/parallel/test-trace-events-category-used.js Backport-PR-URL: #23882 PR-URL: #23698 Refs: #23674 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23698 to v10.x-staging.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes