Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: fix arguments comments #2161

Closed
wants to merge 1 commit into from
Closed

child_process: fix arguments comments #2161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ exports._forkChild = function(fd) {
};


function normalizeExecArgs(command /*, options, callback */) {
function normalizeExecArgs(command /*, options, callback*/) {
var file, args, options, callback;

if (typeof arguments[1] === 'function') {
Expand Down Expand Up @@ -98,7 +98,7 @@ function normalizeExecArgs(command /*, options, callback */) {
}


exports.exec = function(command /*, options, callback */) {
exports.exec = function(command /*, options, callback*/) {
var opts = normalizeExecArgs.apply(null, arguments);
return exports.execFile(opts.file,
opts.args,
Expand All @@ -107,7 +107,7 @@ exports.exec = function(command /*, options, callback */) {
};


exports.execFile = function(file /* args, options, callback */) {
exports.execFile = function(file /*, args, options, callback*/) {
var args, callback;
var options = {
encoding: 'utf8',
Expand Down Expand Up @@ -443,7 +443,7 @@ function checkExecSyncError(ret) {
}


function execFileSync(/*command, options*/) {
function execFileSync(/*command, args, options*/) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the rest should have been done but this one was worthwhile.

var opts = normalizeSpawnArguments.apply(null, arguments);
var inheritStderr = !opts.options.stdio;

Expand All @@ -462,7 +462,7 @@ function execFileSync(/*command, options*/) {
exports.execFileSync = execFileSync;


function execSync(/*comand, options*/) {
function execSync(/*command, options*/) {
var opts = normalizeExecArgs.apply(null, arguments);
var inheritStderr = opts.options ? !opts.options.stdio : true;

Expand Down