Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: fix arguments comments #2161

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Sorry for the noise. While reading through child_process.js, I noticed the commented arguments to execFileSync were wrong. I also found some style inconsistencies and a typo while looking through the other argument comments.

@silverwind silverwind added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jul 11, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Jul 11, 2015

The changes look fine, but it might not be worth the noise.

@thefourtheye
Copy link
Contributor

LGTMT. But do we have a policy against landing just cosmetic changes?

@ronkorving
Copy link
Contributor

Fixing the fact that the commented arguments were incorrect seems more than cosmetic to me.

silverwind added a commit that referenced this pull request Jul 11, 2015
Fixes the arguments comments for execFileSync and other related minor
inconsistencies in commented arguments in the same file.

PR-URL: #2161
Reviewed-By: Colin Ihrig <[email protected]>
@silverwind
Copy link
Contributor Author

Landed in 5acad6b. I think it was worth it as I can't remember which of the spawn variants take args arguments and which don't so having these correct should hopefully help a future reader.

@silverwind silverwind closed this Jul 11, 2015
@@ -443,7 +443,7 @@ function checkExecSyncError(ret) {
}


function execFileSync(/*command, options*/) {
function execFileSync(/*command, args, options*/) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the rest should have been done but this one was worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants