Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace string concatenation with template literals #15924

Closed
wants to merge 3 commits into from
Closed

test: replace string concatenation with template literals #15924

wants to merge 3 commits into from

Conversation

jphblais
Copy link
Contributor

@jphblais jphblais commented Oct 6, 2017 •
edited by refack
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@mscdex mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Oct 6, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 7, 2017
Closed
4 tasks
cjihrig
cjihrig reviewed Oct 7, 2017
View reviewed changes
test/parallel/test-internal-module-map-asserts.js

const moduleMap = new ModuleMap();

assert.throws(() => moduleMap.get({}), errorReg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could DRY this file up a bit if you did something like:

[{}, [], true, 1, () => {}].forEach((value) => {
  assert.throws(() => moduleMap.get(value), errorReg);
});

@refack
Copy link
Contributor

refack commented Oct 7, 2017 •
edited
Loading

Welcome @jphblais and thank you for the contribution 🥇

Quick CI:
https://ci.nodejs.org/job/node-test-commit-linuxone/9075/ ✔️
https://ci.nodejs.org/job/node-test-linter/12291/ ✔️

refack
refack approved these changes Oct 7, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY would be nice.

tniessen
tniessen reviewed Oct 7, 2017
View reviewed changes
test/parallel/test-internal-module-map-asserts.js

assert.throws(() => moduleMap.has(1), errorReg);

assert.throws(() => moduleMap.has(() => {}), errorReg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nit: I would love it if your assertions were not separated by empty lines as long as they do not use more than a single line themselves.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2017

@jphblais would you also be so kind and remove the merge commit by rebasing and force pushing the branch?

@refack refack self-assigned this Oct 9, 2017
@lance
Copy link
Member

lance commented Oct 9, 2017

Full CI: https://ci.nodejs.org/job/node-test-pull-request/10552/

@BridgeAR BridgeAR assigned BridgeAR and unassigned refack Oct 18, 2017
BridgeAR pushed a commit that referenced this pull request Oct 19, 2017
@jphblais @BridgeAR
test: replace concatenation with literals
f05a2d8 
PR-URL: #15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 19, 2017
@jphblais @BridgeAR
test: improve coverage of ModuleMap.js
3b90bd0 
PR-URL: #15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Landed in 3b90bd0 and f05a2d8.

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 19, 2017
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@jphblais @MylesBorins
test: replace concatenation with literals
fe84f3c 
PR-URL: #15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@jphblais @MylesBorins
test: improve coverage of ModuleMap.js
acba6d0 
PR-URL: #15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@jphblais @addaleax
test: replace concatenation with literals
0a2c09c 
PR-URL: nodejs/node#15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@jphblais @addaleax
test: improve coverage of ModuleMap.js
32a05d3 
PR-URL: nodejs/node#15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@jphblais @addaleax
test: replace concatenation with literals
c96a8b4 
PR-URL: nodejs/node#15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@jphblais @addaleax
test: improve coverage of ModuleMap.js
7594bbe 
PR-URL: nodejs/node#15924
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@cjihrig cjihrig cjihrig left review comments

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@refack refack refack approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.