-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: improve coverage of ModuleMap.js
PR-URL: #15924 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
- Loading branch information
1 parent
fe84f3c
commit acba6d0
Showing
1 changed file
with
44 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Flags: --expose-internals | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const ModuleMap = require('internal/loader/ModuleMap'); | ||
|
||
// ModuleMap.get, ModuleMap.has and ModuleMap.set should only accept string | ||
// values as url argument. | ||
{ | ||
const errorReg = common.expectsError({ | ||
code: 'ERR_INVALID_ARG_TYPE', | ||
type: TypeError, | ||
message: /^The "url" argument must be of type string/ | ||
}, 15); | ||
|
||
const moduleMap = new ModuleMap(); | ||
|
||
// As long as the assertion of "job" argument is done after the assertion of | ||
// "url" argument this test suite is ok. Tried to mock the "job" parameter, | ||
// but I think it's useless, and was not simple to mock... | ||
const job = undefined; | ||
|
||
[{}, [], true, 1, () => {}].forEach((value) => { | ||
assert.throws(() => moduleMap.get(value), errorReg); | ||
assert.throws(() => moduleMap.has(value), errorReg); | ||
assert.throws(() => moduleMap.set(value, job), errorReg); | ||
}); | ||
} | ||
|
||
// ModuleMap.set, job argument should only accept ModuleJob values. | ||
{ | ||
const errorReg = common.expectsError({ | ||
code: 'ERR_INVALID_ARG_TYPE', | ||
type: TypeError, | ||
message: /^The "job" argument must be of type ModuleJob/ | ||
}, 5); | ||
|
||
const moduleMap = new ModuleMap(); | ||
|
||
[{}, [], true, 1, () => {}].forEach((value) => { | ||
assert.throws(() => moduleMap.set('', value), errorReg); | ||
}); | ||
} |