Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky child-process-exec-kill-throws #12111

Closed
wants to merge 1 commit into from
Closed

test: fix flaky child-process-exec-kill-throws #12111

wants to merge 1 commit into from

Commits on Mar 30, 2017

  1. test: fix flaky child-process-exec-kill-throws 

    This is a fix for test-child-process-exec-kill-throws which is currently
flaky on Windows.

A bug in the test was causing the child process to fail for reasons
other than those intended by the test. Instead of failing for exceeding
the `maxBuffer` setting, the test was failing because it was trying to
load `internal/child_process` without being passed the
`expose-internals` flag. Move that module to where only the parent
process (which gets the flag) loads it.

Additionally, improve an assertion message to help debug problems like
this.

Fixes: nodejs#12053
    @Trott
    Trott committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    5e7dbdb View commit details
    Browse the repository at this point in the history