Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky child-process-exec-kill-throws #12111

Closed
wants to merge 1 commit into from
Closed

test: fix flaky child-process-exec-kill-throws #12111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ prefix parallel
[true] # This section applies to all platforms

[$system==win32]
# See https://github.com/nodejs/node/issues/12053, this test may be exposing a
# genuine bug with kill() on Windows.
test-child-process-exec-kill-throws : PASS,FLAKY

[$system==linux]

Expand Down
9 changes: 5 additions & 4 deletions test/parallel/test-child-process-exec-kill-throws.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const internalCp = require('internal/child_process');

if (process.argv[2] === 'child') {
// Keep the process alive and printing to stdout.
setInterval(() => { console.log('foo'); }, 1);
// Since maxBuffer is 0, this should trigger an error.
console.log('foo');
} else {
const internalCp = require('internal/child_process');

// Monkey patch ChildProcess#kill() to kill the process and then throw.
const kill = internalCp.ChildProcess.prototype.kill;

Expand All @@ -21,7 +22,7 @@ if (process.argv[2] === 'child') {
const options = { maxBuffer: 0 };
const child = cp.exec(cmd, options, common.mustCall((err, stdout, stderr) => {
// Verify that if ChildProcess#kill() throws, the error is reported.
assert(/^Error: mock error$/.test(err));
assert.strictEqual(err.message, 'mock error', err);
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
assert.strictEqual(child.killed, true);
Expand Down