doc: document R CRAN mirror process #10211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v7.x
benchmark
|
I would prefer just a single safe option, I think half a page of install instructions is kinda scary for the reader. or should be sufficient. |
|
@AndreasMadsen yea, that makes sense, i'll probably use the second option |
lholmquist
force-pushed
the
benchmark-doc-r-10204
branch
from
6283b02
to
acb7b7c
Compare
|
@AndreasMadsen ok, updated and rebased |
|
LGTM. To be clear you should get that message on all platforms, but some may show it as an X11 window, which is what causes the problems. |
|
@AndreasMadsen should i change the heading then? or leave as is? |
|
@lholmquist You could change it to |
lholmquist
force-pushed
the
benchmark-doc-r-10204
branch
from
acb7b7c
to
7af0970
Compare
|
@AndreasMadsen ok, updated and rebased |
AndreasMadsen
approved these changes
Dec 12, 2016
lance
reviewed
Dec 13, 2016
| install.packages("ggplot2", repo="http://cran.us.r-project.org") | ||
| ``` | ||
|
|
||
| Of course, use the mirror that suites your location. |
The current benchmark docs showing how to install R packages doesn't go into how to specify a CRAN mirror. This commit shows how to specify the repo parameter when installing a package. fixes: nodejs#10204
lholmquist
force-pushed
the
benchmark-doc-r-10204
branch
from
7af0970
to
fa5643c
Compare
|
Landed in: eceef76 |
lance
pushed a commit
that referenced
this pull request
Dec 15, 2016
The current benchmark docs showing how to install R packages doesn't go into how to specify a CRAN mirror. This commit shows how to specify the repo parameter when installing a package. Fixes: #10204 PR-URL: #10211 Reviewed-By: Andreas Madsen <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
The current benchmark docs showing how to install R packages doesn't go into how to specify a CRAN mirror. This commit shows how to specify the repo parameter when installing a package. Fixes: #10204 PR-URL: #10211 Reviewed-By: Andreas Madsen <[email protected]>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
The current benchmark docs showing how to install R packages doesn't go into how to specify a CRAN mirror. This commit shows how to specify the repo parameter when installing a package. Fixes: #10204 PR-URL: #10211 Reviewed-By: Andreas Madsen <[email protected]>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
|
It should not be backported, the entire benchmark suite was rewritten in v7 and declared a major change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.
This PR adds 3 options on how to install the needed packages
when a CRAN mirror is asked for.
fixes: #10204