Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark docs: how to select the CRAN Mirror for R #10204

Closed
lholmquist opened this issue Dec 9, 2016 · 7 comments
Closed

Benchmark docs: how to select the CRAN Mirror for R #10204

lholmquist opened this issue Dec 9, 2016 · 7 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.

Comments

@lholmquist
Copy link
Contributor

  • Version: v7.2.0
  • Platform: OS X
  • Subsystem:
    docs

In the benchmarks docs, https://github.com/nodejs/node/blob/master/benchmark/README.md, the instructions say to install 2 R packages,

install.packages("ggplot2") install.packages("plyr")

but running those commands in the R repl returns a --- Please select a CRAN mirror for use in this session ---

should be somehting like this, install.packages("ggplot2", repos="http://cran.us.r-project.org")

I can add a PR

@Fishrock123 Fishrock123 added benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations. labels Dec 9, 2016
@Fishrock123
Copy link
Contributor

cc @AndreasMadsen

@AndreasMadsen
Copy link
Member

AndreasMadsen commented Dec 9, 2016

Sure, we can specify the mirror, but not everybody lives in the US. I don't think entering a number and pressing enter in the REPL is a big issue. This is what my REPL shows:

R

R version 3.3.1 (2016-06-21) -- "Bug in Your Hair"
Copyright (C) 2016 The R Foundation for Statistical Computing
Platform: x86_64-apple-darwin16.0.0 (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> install.packages("ggplot2")
Installing package into ‘/usr/local/lib/R/3.3/site-library’
(as ‘lib’ is unspecified)
--- Please select a CRAN mirror for use in this session ---
HTTPS CRAN mirror

 1: 0-Cloud [https]                 2: Algeria [https]
 3: Australia (Canberra) [https]    4: Australia (Melbourne) [https]
 5: Australia (Perth) [https]       6: Austria [https]
 7: Belgium (Ghent) [https]         8: Brazil (RJ) [https]
 9: Brazil (SP 1) [https]          10: Bulgaria [https]
11: Canada (MB) [https]            12: Chile 1 [https]
13: Chile 2 [https]                14: China (Beijing) [https]
15: China (Hefei) [https]          16: China (Lanzhou) [https]
17: Colombia (Cali) [https]        18: Czech Republic [https]
19: Denmark [https]                20: France (Lyon 1) [https]
21: France (Lyon 2) [https]        22: France (Marseille) [https]
23: France (Montpellier) [https]   24: France (Paris 2) [https]
25: Germany (Falkenstein) [https]  26: Germany (Münster) [https]
27: Iceland [https]                28: India [https]
29: Ireland [https]                30: Italy (Padua) [https]
31: Japan (Tokyo) [https]          32: Malaysia [https]
33: Mexico (Mexico City) [https]   34: New Zealand [https]
35: Norway [https]                 36: Philippines [https]
37: Russia (Moscow) [https]        38: Serbia [https]
39: Spain (A Coruña) [https]       40: Spain (Madrid) [https]
41: Switzerland [https]            42: Taiwan (Chungli) [https]
43: Turkey (Denizli) [https]       44: UK (Bristol) [https]
45: UK (Cambridge) [https]         46: UK (London 1) [https]
47: USA (CA 1) [https]             48: USA (IA) [https]
49: USA (IN) [https]               50: USA (KS) [https]
51: USA (MI 1) [https]             52: USA (TN) [https]
53: USA (TX) [https]               54: USA (WA) [https]
55: (HTTP mirrors)

Selection:

@lholmquist
Copy link
Contributor Author

interesting thing, i don't get that list, but i do get a XQuartz installer pop up, i'll probably add these scenarios to the PR

@Fishrock123
Copy link
Contributor

Yeah, on OS X for me X11 pops up and I didn't see that at the time because I was using two monitors.

@AndreasMadsen
Copy link
Member

AndreasMadsen commented Dec 9, 2016

@lholmquist @Fishrock123 I see, I properly have a custom install of R.

@AndreasMadsen
Copy link
Member

options(menu.graphics = FALSE) will apparently disable X11. But I'm also fine with specifying the repo or documenting X11. I guess specifying the repo is the most foolproof.

@lholmquist
Copy link
Contributor Author

Added the PR: #10211

lholmquist added a commit to lholmquist/node that referenced this issue Dec 13, 2016
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.

This commit shows how to specify the repo parameter when
installing a package.

fixes: nodejs#10204
@lance lance closed this as completed in eceef76 Dec 15, 2016
italoacasas pushed a commit that referenced this issue Dec 17, 2016
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.

This commit shows how to specify the repo parameter when
installing a package.

Fixes: #10204
PR-URL: #10211
Reviewed-By: Andreas Madsen <[email protected]>
cjihrig pushed a commit that referenced this issue Dec 20, 2016
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.

This commit shows how to specify the repo parameter when
installing a package.

Fixes: #10204
PR-URL: #10211
Reviewed-By: Andreas Madsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants