Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: resolve miscellaneous conversion warnings (Windows) #10145

Closed
wants to merge 2 commits into from

Conversation

brodycj
Copy link

@brodycj brodycj commented Dec 6, 2016

Checklist
  • make -j8 test (UNIX [macOS]; Linux i386 & amd64) and vcbuild test nosign (.\vcbuild.bat nosign then .\vcbuild.bat test nosign nobuild as Administrator on Windows) PASS OK
  • commit message follows commit guidelines
Additional item
Affected core subsystem(s)

src

Description of change

Resolve other conversion warnings not covered by #10141/#10142/#10143

This change along with #10140 (build options), #10141 (URL warning fixes), #10142 (crypto warning fixes), and #10143 (dtrace warning fix) resolves all warnings on Windows if vcbuild.bat is called with the following options: noperfctr without-inspector without-profiler

NOTE: This was originally a part of PR #10139 (build, warning, header, and include fixes).

ADDITIONAL NOTE: Some of the changes are marked // TBD POSSIBLE DATA LOSS: since I think we should examine these conversions at some point. I would be happy to take some or all of these out if necessary.

Christopher J. Brody added 2 commits December 6, 2016 15:19
Resolve warning on Windows build
(Windows build)

Some TBD POSSIBLE DATA LOSS scenarios marked.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Dec 6, 2016
@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

/cc @bnoordhuis @addaleax

@brodycj
Copy link
Author

brodycj commented Dec 8, 2016

I would like to submit these fixes in separate PRs for the following reasons:

In case anyone has already started to review (cc @jasnell @bnoordhuis @addaleax) the changes some quick feedback would be appreciated.

@brodycj brodycj closed this Dec 8, 2016
@brodycj brodycj mentioned this pull request Dec 8, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants