-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build, warning, header, and include fixes #10139
Conversation
Hides ugly warnings in Windows build
Resolve macro redefinition warning on Windows
This is to resolve an unused result warning in node_url.cc.
Resolve warning in Ubuntu Linux i386 build
Resolve conversion warning on Windows
Resolve conversion warning on Windows
Resolve warning on Windows build
Some TBD POSSIBLE DATA LOSS scenarios marked.
* remove node_internals.h dependency from node.h; adjust other source * remove break in namespace node block from node.h * move includes to beginning of node.h * remove extra include from node.h
It would probably help quite a bit with the review process if you split this into independent PRs where that makes sense, yes |
Thanks @addaleax, my idea is to split this into 2 parts:
In case part 1 becomes too big I can always split it again. I would also like to wait for part 1 to be reviewed and landed before submitting part 2. Closing for now, please respond if I should do this a different way. |
Checklist
make -j8 test
(UNIX [macOS]; Linux i386 & amd64) andvcbuild test nosign
(.\vcbuild.bat nosign
then.\vcbuild.bat test nosign nobuild
as Administrator on Windows) PASS OKAdditional item
Affected core subsystem(s)
build, crypto, dtrace, url, tls, other src
Description of change
General:
vcbuild
(withnoperfctr
and newwithout-inspector
/without-profiler
options), Ubuntu Linux (i386/amd64), and macOSNODE_WANT_INTERNALS
and extra includesThis PR includes the changes I originally raised in #9757 & #9767.
Details of proposed changes:
--without-profiler
option to build with code related tov8-profiler.h
disabledvcbuild.bat
addwithout-inspector
&without-profiler
optionsurl
,crypto
,dtrace
,tls
, and othersrc
fixes to resolve warnings insrc
on macOS, Ubuntu Linux (i386), and Windows buildsDecodeBytes
&DecodeWrite
to return portableptrdiff_t
type according to TODO note by @tjfontainenode.h
: remove conditional includenode_internals.h
, remove break innode
namespace, etc.NODE_WANT_INTERNALS
fromsrc
andnode.gyp
filessrc
filesOther notes:
.\vcbuild.bat nosign noperfctr without-inspector without-profiler
builds with zero warnings insrc
on Windows with these changes.-Wconversion
I get a bunch of conversion warnings, even with the changes proposed here.// TBD POSSIBLE DATA LOSS:
since I think we should examine these conversions at some point. I would be happy to take some or all of these out if necessary.I put all of these changes together since I think they are indirectly related and think they should be kept in the order proposed here. I kept the
crypto
andtls
changes in separately marked commits. I would be happy to split this into multiple PRs as long as they are not merged out of order. I would also be happy to squash some of the commits and rebase if necessary.TBD items for FUTURE consideration:
CPPLINT_EXCLUDE += src/queue.h
(no longer there)test
src/tree.h to a
deps` subdirectory (easier way to exclude it from cpplint)src/node_root_certs.h
to a special subdirectorysrc
)