Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: editor mode text not saved in .save command #8142

Closed
jcpst opened this issue Aug 17, 2016 · 2 comments
Closed

repl: editor mode text not saved in .save command #8142

jcpst opened this issue Aug 17, 2016 · 2 comments
Labels
feature request Issues that request new features to be added to Node.js. repl Issues and PRs related to the REPL subsystem.

Comments

@jcpst
Copy link

jcpst commented Aug 17, 2016

  • Version: 6.4.0
  • Platform: Linux arch 4.7.0-1-ARCH #1 SMP PREEMPT Mon Aug 8 22:05:58 CEST 2016 x86_64 GNU/Linux
  • Subsystem: repl

The new editor mode is wonderful, but I'm unable to to save what was done in the editor mode using the .save command.

> const foo = 1
undefined
> const bar = 'two'
undefined
> .editor
// Entering editor mode (^D to finish, ^C to cancel)
function fooey () {
  return 'fooey'
}
undefined
> fooey()
'fooey'
> .save zzz.js
Session saved to:zzz.js

zzz.js:

const foo = 1
const bar = 'two'

fooey()
@addaleax addaleax added the repl Issues and PRs related to the REPL subsystem. label Aug 17, 2016
@addaleax
Copy link
Member

/cc @princejwesley

@princejwesley
Copy link
Contributor

@addaleax I'll share the fix shortly

@Fishrock123 Fishrock123 added the feature request Issues that request new features to be added to Node.js. label Aug 19, 2016
princejwesley added a commit to princejwesley/node that referenced this issue Aug 19, 2016
evanlucas pushed a commit that referenced this issue Aug 24, 2016
Fixes: #8142
PR-URL: #8145
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants