Skip to content

Commit

Permalink
repl: Failed to save editor mode text in .save
Browse files Browse the repository at this point in the history
Fixes: #8142
PR-URL: #8145
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
princejwesley committed Aug 20, 2016
1 parent ccbb3c7 commit f6a7434
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,7 @@ function REPLServer(prompt,

if (self.editorMode) {
self.bufferedCommand += cmd + '\n';
self.memory(cmd);
return;
}

Expand Down
20 changes: 20 additions & 0 deletions test/parallel/test-repl-.save.load.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,26 @@ putIn.run(['.save ' + saveFileName]);
// the file should have what I wrote
assert.equal(fs.readFileSync(saveFileName, 'utf8'), testFile.join('\n') + '\n');

{
// save .editor mode code
const cmds = [
'function testSave() {',
'return "saved";',
'}'
];
const putIn = new common.ArrayStream();
const replServer = repl.start('', putIn);

putIn.run(['.editor']);
putIn.run(cmds);
replServer.write('', {ctrl: true, name: 'd'});

putIn.run([`.save ${saveFileName}`]);
replServer.close();
assert.strictEqual(fs.readFileSync(saveFileName, 'utf8'),
`${cmds.join('\n')}\n`);
}

// make sure that the REPL data is "correct"
// so when I load it back I know I'm good
testMe.complete('inner.o', function(error, data) {
Expand Down

0 comments on commit f6a7434

Please sign in to comment.