V8 test failures on PPC after upgrade to 5.0 (test issue) #6236
Comments
mscdex
added
v8 engine
|
I personally prefer the first option. Moving up to a new version of V8 always requires an audit of the currently floating patches to see if they need to be refloated. |
|
Ok sounds good will put together the PR. |
2 tasks
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this issue
Apr 25, 2016
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: nodejs#6267 Fixes: nodejs#6236 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this issue
Apr 26, 2016
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: #6267 Fixes: #6236 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New failures in this job https://ci.nodejs.org/job/node-test-commit-v8-linux/54/ after the upgrade to the 5.0 level of v8
The failures are in these tests:
We were aware of these as they had failed in our runs on 5.0 while it was in beta. The are both test issues as opposed to functional issues. We did not manage to get the fixes in, in one case because there was reluctance to a backport as the feature is not enabled/supported (asm-wasm) and the other we ran out of time to fix up the test. In both cases we they are resolved in v8 master.
For now I can either:
The advantage to the latter is that I think there would be less work when we move up to 5.1 (to realize and not apply floating patch). The downside is that anybody who runs this test on their own would see the failures (which I think would be a limited set of people, particularly since they are only on PPC). @ofrobots which of these would you favor ?
The text was updated successfully, but these errors were encountered: