Skip to content

Commit

Permalink
deps: exclude tests on ppc for v8 5.0
Browse files Browse the repository at this point in the history
There were 2 issues which either the v8 team was reluctant to
backport the fix because the fix was for a disabled feature (wasm) or
that we did not have time to investigate before 5.0 was cut
which result in v8 test failures for PPC in 5.0.  These are test
issues and are already resolved in v8 master.  This PR
excludes these tests so that our v8 tests in the CI will
be green so that we can detect any real regressions.

PR-URL: #6267
Fixes: #6236
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
mhdawson committed Apr 20, 2016
1 parent 7fc4b31 commit 0899ea7
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
7 changes: 7 additions & 0 deletions deps/v8/test/cctest/cctest.status
Original file line number Diff line number Diff line change
Expand Up @@ -615,4 +615,11 @@
'test-api/InitializeDefaultIsolateOnSecondaryThread1': [PASS, ['mode == debug', FAIL]],
}],

##############################################################################
# exclude test issues for which fixes for PPC did not make it into 5.0
# These should be removed when we upgrade Node.js to use v8 5.1
['arch == ppc64', {
'test-heap/ReleaseOverReservedPages' : [SKIP],
}], # 'arch == ppc64''

]
7 changes: 7 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
Original file line number Diff line number Diff line change
Expand Up @@ -923,4 +923,11 @@
'big-array-literal': [SKIP],
}], # 'gcov_coverage'

##############################################################################
# exclude test issues for which fixes for PPC did not make it into 5.0
# These should be removed when we upgrade Node.js to use v8 5.1
['arch == ppc64', {
'wasm/asm-wasm' : [SKIP],
}], # 'arch == ppc64''

]

0 comments on commit 0899ea7

Please sign in to comment.