-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL.canParse fails when stressed #48816
Comments
another test in my end doing a 100ms wait wil not have the same beharviour in that case return true always: import { setTimeout } from 'timers/promises';
while (true) {
await setTimeout(100);
const test = URL.canParse('/ ', 'http://n');
console.log(test);
} this will also fail at some point so maybe the 100 ms will aso fail just didnt get the point were it will fail import { setTimeout } from 'timers/promises';
while (true) {
await setTimeout(1);
const test = URL.canParse('/ ', 'http://n');
console.log(test);
} |
@anonrig i think you are following this changes so you may have all the details about this |
Thanks for the bug report. I confirm this is indeed a really awkward bug. cc @nodejs/url |
This is probably due to v8 Fast API. When you call it multiple times, it triggers v8 fast api. |
@KhafraDev disabling/commenting out V8 Fast API fixes the bug |
> nodejs/node#48816 This was an unsafe change that caused errors to the user due to a bug in Node and a fix will get upstreamed soon but in the meantime we should reverse this. Reverts #52353
Version
20.4.0
Platform
any
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
after some stress
What is the expected behavior? Why is that the expected behavior?
same result as first one
What do you see instead?
return false at some point of stress
Additional information
No response
The text was updated successfully, but these errors were encountered: